From: David Miller <davem@davemloft.net>
To: kurup.manish@gmail.com
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
jakub.kicinski@netronome.com,
pieter.jansenvanvuuren@netronome.com, simon.horman@netronome.com,
john.hurley@netronome.com, oss-drivers@netronome.com,
netdev@vger.kernel.org, aring@mojatatu.com, mrv@mojatatu.com,
manish.kurup@verizon.com
Subject: Re: [PATCH net-next v7 0/3] nfp act_vlan: Rewrite of the TC vlan action to use the RCU, and incorporated review comments
Date: Fri, 10 Nov 2017 14:53:26 +0900 (KST) [thread overview]
Message-ID: <20171110.145326.1999880909720356981.davem@davemloft.net> (raw)
In-Reply-To: <1510062600-32377-1-git-send-email-manish.kurup@verizon.com>
From: Manish Kurup <kurup.manish@gmail.com>
Date: Tue, 7 Nov 2017 08:50:00 -0500
> This commit consists of 3 patches:
>
> patch1 (1/3):
> The VLAN action maintains one set of stats across all cores, and uses a
> spinlock to synchronize updates to it from the same. Changed this to use a
> per-CPU stats context instead.
> This change will result in better performance.
>
> patch2 (2/3):
> Modified netronome nfp flower action to use VLAN helper functions instead
> of accessing/referencing TC act_vlan private structures directly.
>
> patch3 (3/3):
> Using a spinlock in the VLAN action causes performance issues when the VLAN
> action is used on multiple cores. Rewrote the VLAN action to use RCU read
> locking for reads and updates instead.
> All functions now use an RCU dereferenced pointer to access the VLAN action
> context. Modified helper functions used by other modules, to use the RCU as
> opposed to directly accessing the structure.
>
> As part of this review, there were some changes suggested by reviewers.
> I have incorporated all the changes that were requested.
...
Series applied, thank you.
next prev parent reply other threads:[~2017-11-10 5:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 13:50 [PATCH net-next v7 0/3] nfp act_vlan: Rewrite of the TC vlan action to use the RCU, and incorporated review comments Manish Kurup
2017-11-10 5:53 ` David Miller [this message]
2017-11-10 12:30 ` Manish Kurup
2017-11-10 13:39 ` David Miller
2017-11-10 13:54 ` Manish Kurup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110.145326.1999880909720356981.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aring@mojatatu.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.hurley@netronome.com \
--cc=kurup.manish@gmail.com \
--cc=manish.kurup@verizon.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pieter.jansenvanvuuren@netronome.com \
--cc=simon.horman@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).