From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v7 0/3] nfp act_vlan: Rewrite of the TC vlan action to use the RCU, and incorporated review comments Date: Fri, 10 Nov 2017 14:53:26 +0900 (KST) Message-ID: <20171110.145326.1999880909720356981.davem@davemloft.net> References: <1510062600-32377-1-git-send-email-manish.kurup@verizon.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, jakub.kicinski@netronome.com, pieter.jansenvanvuuren@netronome.com, simon.horman@netronome.com, john.hurley@netronome.com, oss-drivers@netronome.com, netdev@vger.kernel.org, aring@mojatatu.com, mrv@mojatatu.com, manish.kurup@verizon.com To: kurup.manish@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:51036 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbdKJFxd (ORCPT ); Fri, 10 Nov 2017 00:53:33 -0500 In-Reply-To: <1510062600-32377-1-git-send-email-manish.kurup@verizon.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Manish Kurup Date: Tue, 7 Nov 2017 08:50:00 -0500 > This commit consists of 3 patches: > > patch1 (1/3): > The VLAN action maintains one set of stats across all cores, and uses a > spinlock to synchronize updates to it from the same. Changed this to use a > per-CPU stats context instead. > This change will result in better performance. > > patch2 (2/3): > Modified netronome nfp flower action to use VLAN helper functions instead > of accessing/referencing TC act_vlan private structures directly. > > patch3 (3/3): > Using a spinlock in the VLAN action causes performance issues when the VLAN > action is used on multiple cores. Rewrote the VLAN action to use RCU read > locking for reads and updates instead. > All functions now use an RCU dereferenced pointer to access the VLAN action > context. Modified helper functions used by other modules, to use the RCU as > opposed to directly accessing the structure. > > As part of this review, there were some changes suggested by reviewers. > I have incorporated all the changes that were requested. ... Series applied, thank you.