netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] sfc: don't warn on successful change of MAC
@ 2017-11-07 17:30 Bert Kenward
  2017-11-10  6:13 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Bert Kenward @ 2017-11-07 17:30 UTC (permalink / raw)
  To: Dave Miller; +Cc: netdev, linux-net-drivers, Robert Stonehouse

From: Robert Stonehouse <rstonehouse@solarflare.com>

Fixes: 535a61777f44e ("sfc: suppress handled MCDI failures when changing the MAC address")
Signed-off-by: Bert Kenward <bkenward@solarflare.com>
---
 drivers/net/ethernet/sfc/ef10.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
index 19a91881fbf9..46d60013564c 100644
--- a/drivers/net/ethernet/sfc/ef10.c
+++ b/drivers/net/ethernet/sfc/ef10.c
@@ -5734,7 +5734,7 @@ static int efx_ef10_set_mac_address(struct efx_nic *efx)
 		 * MCFW do not support VFs.
 		 */
 		rc = efx_ef10_vport_set_mac_address(efx);
-	} else {
+	} else if (rc) {
 		efx_mcdi_display_error(efx, MC_CMD_VADAPTOR_SET_MAC,
 				       sizeof(inbuf), NULL, 0, rc);
 	}
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] sfc: don't warn on successful change of MAC
  2017-11-07 17:30 [PATCH net-next] sfc: don't warn on successful change of MAC Bert Kenward
@ 2017-11-10  6:13 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-11-10  6:13 UTC (permalink / raw)
  To: bkenward; +Cc: netdev, linux-net-drivers, rstonehouse

From: Bert Kenward <bkenward@solarflare.com>
Date: Tue, 7 Nov 2017 17:30:30 +0000

> From: Robert Stonehouse <rstonehouse@solarflare.com>
> 
> Fixes: 535a61777f44e ("sfc: suppress handled MCDI failures when changing the MAC address")
> Signed-off-by: Bert Kenward <bkenward@solarflare.com>

Applied, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-10  6:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-07 17:30 [PATCH net-next] sfc: don't warn on successful change of MAC Bert Kenward
2017-11-10  6:13 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).