From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: rt2x00: use monotonic timestamps for frame dump Date: Fri, 10 Nov 2017 02:34:39 +0000 (UTC) Message-ID: <20171110023439.DF069607EF@smtp.codeaurora.org> References: <20171106140412.1532617-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Stanislaw Gruszka , Helmut Schaa , Arnd Bergmann , Johannes Berg , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Arnd Bergmann Return-path: In-Reply-To: <20171106140412.1532617-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Arnd Bergmann wrote: > rt2x00 uses the deprecated do_gettimeofday() function to get a timestamp > for its debugfs "dump" file interface. > > The timestamp is using an unsigned 32-bit value, so we could make it > work until 2106 by using ktime_get_real_ts64(), but it seems better to > use monotonic times, as we normally want for timestamps. > > Since this is an interface change, I'm incrementing the > DUMP_HEADER_VERSION number, so user space can figure out whether the > timestamps are monotonic or not. Most likely the tools won't care either > way. > > Generally speaking, ABI version numbers and in particular changing them > is a bad idea. However since this is in debugfs, we don't put any > API stability rules on the interface according to > Documentation/filesystems/debugfs.txt, and we can take the easy way > out here; anyone using the frame dump feature can probably work out > the differences here. > > Signed-off-by: Arnd Bergmann Patch applied to wireless-drivers-next.git, thanks. f87eba996bac rt2x00: use monotonic timestamps for frame dump -- https://patchwork.kernel.org/patch/10043531/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches