From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH iproute2 2/2] devlink: add batch command support
Date: Fri, 10 Nov 2017 21:47:35 +0200
Message-ID: <20171110194735.GN18825@mtr-leonro.local>
References: <20171110062014.2693-1-ivecera@redhat.com>
 <20171110062014.2693-3-ivecera@redhat.com>
 <20171110065727.GM18825@mtr-leonro.local>
 <3c672b8b-d3ca-1d50-c4e1-78a36aae6ed7@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="yKkOmjQZXRsvHRX8"
Cc: netdev@vger.kernel.org, jiri@mellanox.com, arkadis@mellanox.com
To: Ivan Vecera <ivecera@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.99]:35368 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753562AbdKJTrl (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 10 Nov 2017 14:47:41 -0500
Content-Disposition: inline
In-Reply-To: <3c672b8b-d3ca-1d50-c4e1-78a36aae6ed7@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


--yKkOmjQZXRsvHRX8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Nov 10, 2017 at 08:10:43AM +0100, Ivan Vecera wrote:
> On 10.11.2017 07:57, Leon Romanovsky wrote:
> > On Fri, Nov 10, 2017 at 07:20:14AM +0100, Ivan Vecera wrote:
> >> The patch adds support to batch devlink commands.
> >>
> >> Cc: Jiri Pirko <jiri@mellanox.com>
> >> Cc: Arkadi Sharshevsky <arkadis@mellanox.com>
> >> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> >> ---
> >>  devlink/devlink.c  | 70 +++++++++++++++++++++++++++++++++++++++++++++++-------
> >>  man/man8/devlink.8 | 16 +++++++++++++
> >>  2 files changed, 78 insertions(+), 8 deletions(-)
> >>
> >
> > <..>
> >
> >> diff --git a/man/man8/devlink.8 b/man/man8/devlink.8
> >> index a480766c..a975ef34 100644
> >> --- a/man/man8/devlink.8
> >> +++ b/man/man8/devlink.8
> >> @@ -12,6 +12,12 @@ devlink \- Devlink tool
> >>  .sp
> >>
> >>  .ti -8
> >> +.B devlink
> >> +.RB "[ " -force " ] "
> >> +.BI "-batch " filename
> >> +.sp
> >> +
> >> +.ti -8
> >>  .IR OBJECT " := { "
> >>  .BR dev " | " port " | " monitor " }"
> >>  .sp
> >> @@ -32,6 +38,16 @@ Print the version of the
> >>  utility and exit.
> >>
> >>  .TP
> >> +.BR "\-b", " \-batch " <FILENAME>
> >> +Read commands from provided file or standard input and invoke them.
> >> +First failure will cause termination of devlink.
> >
> > It is worth to document the expected format of that file.
> > And IMHO, it is better to have ability to load JSON fie which was
> > generated by -j, instead of declaring new format/knob.
> It's just a list of command-lines... like other utils (bridge,ip...)

I'm implementing similar thing in RDMAtool (part of iproute2) and choose JSON
approach, it is more user and script friendly.

Thanks

>
> I.
>




--yKkOmjQZXRsvHRX8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAloGAlcACgkQ5GN7iDZy
WKeTug/+J2oZmu+vTwtj2hzR5flU4pdx/xq9munsWvtbaGCpLHGz+Hk7yyJ+ZY5i
T3cMmOnvUcQxap+DNODJ2KLaeHsI2Aq/XtwwHDoZz+SGqbQ4WmtVyJQGdGwWc7qv
+Jash0LYM9O/dqPVzEbZPop+hkFQDzukgOZKTV8JLwcPPl1gHtkUjaNkxkn4Rirk
bh05iypPHXHGoPop1LBTButely7hQc5LVDOxI+KoK4BvNs/GPiR6t2ZWUxWA0OtP
F24wMdVE0FTgzxN0KEYwz4z4n4WUNNRsQ03FvcTPDHfwJsN3DkTeGpT7dTgIyNgE
wzkrJTJp0SvSet6BQgMp4h0majsu49DSYaB2w2FHWfc10Q/MYZMygTg9sCjlmawc
ezeyWDt7YQzCsV5zxobpMbAVRIAV64vEjIvEvAgBnboykGnp/rwfLgmQWMDsPaZl
RcQono9vpCXNo67A1JN48deea/MaX80SUtSqAIRertAFj8YQRhwZvZ3SlUAVQRhE
9Rp5hjWESoIC/woar8xiI5eDkusyBPh5pEJ7WFQUb/PdGX/wjYPunZJ7x1rQjHw+
rp6UM1nEAzbZ3OBcSp8mvt0kTYubKgIM3Y+zY3cbVxgI6mp5Kg5IYTh4gFjQf5H3
xck5TdKKNHIHEb8P7d629WYLBMxZ8VECNkm24q3mzessi6Fam1I=
=ABZr
-----END PGP SIGNATURE-----

--yKkOmjQZXRsvHRX8--