From: David Miller <davem@davemloft.net>
To: zenczykowski@gmail.com
Cc: maze@google.com, netdev@vger.kernel.org, lorenzo@google.com,
ek@google.com
Subject: Re: [PATCH] net: ipv6: sysctl to specify IPv6 ND traffic class
Date: Sat, 11 Nov 2017 15:13:26 +0900 (KST) [thread overview]
Message-ID: <20171111.151326.977990594563913119.davem@davemloft.net> (raw)
In-Reply-To: <20171108055209.54459-1-zenczykowski@gmail.com>
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Tue, 7 Nov 2017 21:52:09 -0800
> From: Maciej Żenczykowski <maze@google.com>
>
> Add a per-device sysctl to specify the default traffic class to use for
> kernel originated IPv6 Neighbour Discovery packets.
>
> Currently this includes:
>
> - Router Solicitation (ICMPv6 type 133)
> ndisc_send_rs() -> ndisc_send_skb() -> ip6_nd_hdr()
>
> - Neighbour Solicitation (ICMPv6 type 135)
> ndisc_send_ns() -> ndisc_send_skb() -> ip6_nd_hdr()
>
> - Neighbour Advertisement (ICMPv6 type 136)
> ndisc_send_na() -> ndisc_send_skb() -> ip6_nd_hdr()
>
> - Redirect (ICMPv6 type 137)
> ndisc_send_redirect() -> ndisc_send_skb() -> ip6_nd_hdr()
>
> and if the kernel ever gets around to generating RA's,
> it would presumably also include:
>
> - Router Advertisement (ICMPv6 type 134)
> (radvd daemon could pick up on the kernel setting and use it)
>
> Interface drivers may examine the Traffic Class value and translate
> the DiffServ Code Point into a link-layer appropriate traffic
> prioritization scheme. An example of mapping IETF DSCP values to
> IEEE 802.11 User Priority values can be found here:
>
> https://tools.ietf.org/html/draft-ietf-tsvwg-ieee-802-11
>
> The expected primary use case is to properly prioritize ND over wifi.
>
> Testing:
...
> (based on original change written by Erik Kline, with minor changes)
>
> v2: fix 'suspicious rcu_dereference_check() usage'
> by explicitly grabbing the rcu_read_lock.
>
> Cc: Lorenzo Colitti <lorenzo@google.com>
> Signed-off-by: Erik Kline <ek@google.com>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
Applied to net-next, thanks.
prev parent reply other threads:[~2017-11-11 6:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 7:59 [PATCH] net: ipv6: sysctl to specify IPv6 ND traffic class Maciej Żenczykowski
2017-11-08 4:29 ` Erik Kline
2017-11-08 5:52 ` Maciej Żenczykowski
2017-11-11 6:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171111.151326.977990594563913119.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ek@google.com \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).