From: David Miller <davem@davemloft.net>
To: u9012063@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCHv2 net-next 1/3] ip_gre: Refector the erpsan tunnel code.
Date: Sat, 11 Nov 2017 19:07:52 +0900 (KST) [thread overview]
Message-ID: <20171111.190752.966814845978749563.davem@davemloft.net> (raw)
In-Reply-To: <1510186384-16411-2-git-send-email-u9012063@gmail.com>
From: William Tu <u9012063@gmail.com>
Date: Wed, 8 Nov 2017 16:13:02 -0800
> +static void erspan_build_header(struct sk_buff *skb,
> + __be32 id, u32 index,
> + bool truncate, bool is_ipv4)
> +{
Please do not put large non-inline functions into header files.
next prev parent reply other threads:[~2017-11-11 10:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 0:13 [PATCHv2 net-next 0/3] ip6_gre: add erspan native tunnel for ipv6 William Tu
2017-11-09 0:13 ` [PATCHv2 net-next 1/3] ip_gre: Refector the erpsan tunnel code William Tu
2017-11-11 10:07 ` David Miller [this message]
2017-11-13 15:14 ` William Tu
2017-11-09 0:13 ` [PATCHv2 net-next 2/3] ip6_gre: Refactor ip6gre xmit codes William Tu
2017-11-09 0:31 ` Florian Westphal
2017-11-09 0:13 ` [PATCHv2 net-next 3/3] ip6_gre: Add ERSPAN native tunnel support William Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171111.190752.966814845978749563.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).