From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCHv2 net-next 1/3] ip_gre: Refector the erpsan tunnel code.
Date: Sat, 11 Nov 2017 19:07:52 +0900 (KST)
Message-ID: <20171111.190752.966814845978749563.davem@davemloft.net>
References: <1510186384-16411-1-git-send-email-u9012063@gmail.com>
        <1510186384-16411-2-git-send-email-u9012063@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: u9012063@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:46100 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750896AbdKKKHy (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 11 Nov 2017 05:07:54 -0500
In-Reply-To: <1510186384-16411-2-git-send-email-u9012063@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: William Tu <u9012063@gmail.com>
Date: Wed,  8 Nov 2017 16:13:02 -0800

> +static void erspan_build_header(struct sk_buff *skb,
> +				__be32 id, u32 index,
> +				bool truncate, bool is_ipv4)
> +{

Please do not put large non-inline functions into header files.