From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] qlge: remove duplicated assignment to mbcp Date: Sat, 11 Nov 2017 19:13:54 +0900 (KST) Message-ID: <20171111.191354.1268716566266491493.davem@davemloft.net> References: <20171109075215.2666-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: harish.patil@cavium.com, manish.chopra@cavium.com, Dept-GELinuxNICDev@cavium.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: colin.king@canonical.com Return-path: In-Reply-To: <20171109075215.2666-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin King Date: Thu, 9 Nov 2017 07:52:15 +0000 > From: Colin Ian King > > The assignment to mbcp is identical to the initiatialized value assigned > to mbcp at declaration time a few lines earlier, hence we can remove the > second redundant assignment. Cleans up clang warning: > > drivers/net/ethernet/qlogic/qlge/qlge_mpi.c:209:22: warning: > Value stored to 'mbcp' during its initialization is never read > > Signed-off-by: Colin Ian King Applied, thanks.