From: Florian Westphal <fw@strlen.de>
To: Vasily Averin <vvs@virtuozzo.com>
Cc: netdev@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCH v4 12/18] nfnetlink_gueue: exit_net cleanup check added
Date: Sun, 12 Nov 2017 09:52:32 +0100 [thread overview]
Message-ID: <20171112085232.GJ5512@breakpoint.cc> (raw)
In-Reply-To: <c0d49d64-d46b-21e6-02e4-4c445600bd39@virtuozzo.com>
Vasily Averin <vvs@virtuozzo.com> wrote:
> Be sure that instance_table array initialized in net_init hook
> was return to initial state.
> + for (i = 0; i < INSTANCE_BUCKETS; i++)
> + if (WARN_ON_ONCE(!hlist_empty(&q->instance_table[i])))
> + break;
This looks strange, why if/break?
Plain WARN_ON_ONCE should be enough, but thats a nit so:
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2017-11-12 8:53 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 9:58 [PATCH 00/21] exit_net checks for objects initialized in net_init hook Vasily Averin
2017-11-05 16:49 ` [PATCH v2 " Vasily Averin
2017-11-06 13:22 ` [PATCH v3 " Vasily Averin
2017-11-12 8:39 ` [PATCH v4 00/18] " Vasily Averin
2017-11-12 15:06 ` Vasily Averin
2017-11-12 19:26 ` [PATCH v5 00/13] " Vasily Averin
2017-11-14 6:47 ` David Miller
[not found] ` <20171114.154720.1071922306148362515.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2017-11-14 14:41 ` Vasily Averin
2017-11-12 19:26 ` [PATCH v5 01/13] af_key: replace BUG_ON on WARN_ON in net_exit hook Vasily Averin
2017-11-12 19:27 ` [PATCH v5 02/13] geneve: exit_net cleanup check added Vasily Averin
2017-11-12 19:27 ` [PATCH v5 03/13] packet: " Vasily Averin
2017-11-12 19:28 ` [PATCH v5 04/13] vxlan: exit_net cleanup checks added Vasily Averin
2017-11-12 19:28 ` [PATCH v5 05/13] netdev: exit_net cleanup check added Vasily Averin
2017-11-12 19:29 ` [PATCH v5 06/13] fib_notifier: " Vasily Averin
2017-11-12 19:30 ` [PATCH v5 07/13] fib_rules: " Vasily Averin
2017-11-12 19:30 ` [PATCH v5 08/13] l2tp: " Vasily Averin
[not found] ` <cb06dace-88a8-fecf-92ad-02920920a0d3-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2017-11-12 19:31 ` [PATCH v5 09/13] nfs client: " Vasily Averin
2017-11-12 19:32 ` [PATCH v5 10/13] sunrpc: " Vasily Averin
2017-11-12 19:32 ` [PATCH v5 11/13] phonet: " Vasily Averin
2017-11-12 19:33 ` [PATCH v5 12/13] ppp: exit_net cleanup checks added Vasily Averin
2017-11-12 19:34 ` [PATCH v5 13/13] xfrm6_tunnel: exit_net cleanup check added Vasily Averin
2017-11-12 8:39 ` [PATCH v4 01/18] af_key: replace BUG_ON on WARN_ON in net_exit hook Vasily Averin
2017-11-12 8:40 ` [PATCH v4 02/18] geneve: exit_net cleanup check added Vasily Averin
2017-11-12 8:41 ` [PATCH v4 03/18] packet: " Vasily Averin
2017-11-12 8:42 ` [PATCH v4 04/18] vxlan: exit_net cleanup checks added Vasily Averin
2017-11-12 8:42 ` [PATCH v4 05/18] netdev: exit_net cleanup check added Vasily Averin
2017-11-12 8:42 ` [PATCH v4 06/18] fib_notifier: " Vasily Averin
2017-11-12 8:43 ` [PATCH v4 07/18] fib_rules: " Vasily Averin
2017-11-12 8:44 ` [PATCH v4 08/18] l2tp: " Vasily Averin
2017-11-12 8:44 ` [PATCH v4 09/18] clusterip: " Vasily Averin
2017-11-12 8:45 ` [PATCH v4 10/18] nf_tables: " Vasily Averin
2017-11-12 8:46 ` [PATCH v4 11/18] nfnetlink_log: " Vasily Averin
2017-11-12 8:53 ` Florian Westphal
2017-11-12 11:28 ` Sergei Shtylyov
2017-11-12 8:47 ` [PATCH v4 12/18] nfnetlink_gueue: " Vasily Averin
2017-11-12 8:52 ` Florian Westphal [this message]
2017-11-12 9:02 ` Vasily Averin
2017-11-12 8:47 ` [PATCH v4 13/18] x_tables: " Vasily Averin
[not found] ` <9dfa013e-9098-e155-9c47-a73753338288-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2017-11-12 8:48 ` [PATCH v4 14/18] nfs client: " Vasily Averin
2017-11-12 8:48 ` [PATCH v4 15/18] sunrpc: " Vasily Averin
2017-11-12 8:49 ` [PATCH v4 16/18] phonet: " Vasily Averin
2017-11-12 8:50 ` [PATCH v4 17/18] ppp: exit_net cleanup checks added Vasily Averin
2017-11-12 8:51 ` [PATCH v4 18/18] xfrm6_tunnel: exit_net cleanup check added Vasily Averin
2017-11-06 13:23 ` [PATCH v3 02/21] lockd: added cleanup checks in exit_net hook Vasily Averin
2017-11-09 15:06 ` J. Bruce Fields
2017-11-06 13:23 ` [PATCH v3 03/21] exit_net cleanup: geneve sock_list check Vasily Averin
2017-11-06 13:23 ` [PATCH v3 04/21] ppp: exit_net cleanup checks added Vasily Averin
2017-11-06 13:34 ` walter harms
2017-11-06 13:23 ` [PATCH v3 05/21] vxlan: " Vasily Averin
2017-11-06 13:24 ` [PATCH v3 06/21] netdev: exit_net cleanup check added Vasily Averin
[not found] ` <4fdc4264-e338-6ee8-a662-7d98b45733a1-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2017-11-06 13:22 ` [PATCH v3 01/21] grace: replace BUG_ON by WARN_ONCE in exit_net hook Vasily Averin
2017-11-06 20:02 ` J. Bruce Fields
[not found] ` <a059abdd-e727-adcb-7b43-976be1d0a08e-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2017-11-09 15:06 ` J. Bruce Fields
2017-11-06 13:24 ` [PATCH v3 07/21] nfs4blocklayout: exit_net cleanup check added Vasily Averin
2017-11-06 13:24 ` [PATCH v3 08/21] nfs client: " Vasily Averin
2017-11-06 13:24 ` [PATCH v3 09/21] fib_notifier: " Vasily Averin
2017-11-06 13:24 ` [PATCH v3 10/21] fib_rules: " Vasily Averin
2017-11-06 13:24 ` [PATCH v3 11/21] clusterip: " Vasily Averin
2017-11-06 13:40 ` Jozsef Kadlecsik
2017-11-06 13:24 ` [PATCH v3 12/21] xfrm6_tunnel: " Vasily Averin
2017-11-06 13:25 ` [PATCH v3 13/21] af_key: replace BUG_ON on WARN_ONCE in net_exit hook Vasily Averin
2017-11-06 13:25 ` [PATCH v3 14/21] l2tp: exit_net cleanup check added Vasily Averin
2017-11-06 13:25 ` [PATCH v3 15/21] nf_tables: " Vasily Averin
2017-11-06 13:25 ` [PATCH v3 16/21] nfnetlink_log: " Vasily Averin
2017-11-06 13:25 ` [PATCH v3 17/21] nfnetlink_gueue: " Vasily Averin
2017-11-06 13:25 ` [PATCH v3 18/21] x_tables: " Vasily Averin
2017-11-06 13:25 ` [PATCH v3 19/21] packet: " Vasily Averin
2017-11-06 13:25 ` [PATCH v3 20/21] phonet: " Vasily Averin
2017-11-06 19:37 ` Rémi Denis-Courmont
2017-11-12 9:24 ` Vasily Averin
2017-11-06 13:26 ` [PATCH v3 21/21] sunrpc: " Vasily Averin
2017-11-05 16:49 ` [PATCH v2 01/21] exit_net cleanup: geneve sock_list check Vasily Averin
2017-11-07 2:37 ` kbuild test robot
2017-11-05 16:49 ` [PATCH v2 02/21] ppp: exit_net cleanup checks added Vasily Averin
2017-11-05 16:49 ` [PATCH v2 03/21] vxlan: " Vasily Averin
2017-11-05 16:49 ` [PATCH v2 04/21] netdev: exit_net cleanup check added Vasily Averin
2017-11-05 16:49 ` [PATCH v2 05/21] nfs4blocklayout: " Vasily Averin
2017-11-05 16:50 ` [PATCH v2 07/21] fib_notifier: " Vasily Averin
2017-11-05 16:50 ` [PATCH v2 08/21] fib_rules: " Vasily Averin
2017-11-05 16:50 ` [PATCH v2 09/21] clusterip: " Vasily Averin
2017-11-07 2:42 ` kbuild test robot
2017-11-05 16:50 ` [PATCH v2 10/21] xfrm6_tunnel: " Vasily Averin
2017-11-05 16:50 ` [PATCH v2 11/21] af_key: replace BUG_ON on WARN_ON in net_exit hook Vasily Averin
2017-11-05 16:50 ` [PATCH v2 12/21] l2tp: exit_net cleanup check added Vasily Averin
2017-11-05 16:50 ` [PATCH v2 13/21] nf_tables: " Vasily Averin
2017-11-05 16:51 ` [PATCH v2 14/21] nfnetlink_log: " Vasily Averin
2017-11-05 16:51 ` [PATCH v2 15/21] nfnetlink_gueue: " Vasily Averin
2017-11-05 16:51 ` [PATCH v2 16/21] x_tables: " Vasily Averin
2017-11-05 16:51 ` [PATCH v2 17/21] hashlimit: " Vasily Averin
2017-11-05 16:51 ` [PATCH v2 18/21] recent: " Vasily Averin
2017-11-05 16:51 ` [PATCH v2 19/21] packet: " Vasily Averin
2017-11-05 16:51 ` [PATCH v2 20/21] phonet: " Vasily Averin
[not found] ` <bafb347d-e36e-8b2b-7646-afc458a7a32a-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2017-11-05 16:50 ` [PATCH v2 06/21] nfs client: " Vasily Averin
2017-11-05 16:52 ` [PATCH v2 21/21] sunrpc: " Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171112085232.GJ5512@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).