netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
	xiyou.wangcong@gmail.com, jiri@resnulli.us,
	andre.guedes@intel.com, vinicius.gomes@intel.com,
	ivan.briano@intel.com
Subject: Re: [PATCH iproute2] man: Clarify idleslope calculation for tc-cbs
Date: Sun, 12 Nov 2017 15:58:45 -0800	[thread overview]
Message-ID: <20171112155845.69a079ae@xeon-e3> (raw)
In-Reply-To: <20171110223436.18221-1-jesus.sanchez-palencia@intel.com>

On Fri, 10 Nov 2017 14:34:36 -0800
Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com> wrote:

> In order to calculate the idleSlope parameter of CBS correctly, users
> must take into account the entire packet size, including the overhead
> from all layers.
> 
> Add some more details to the man page to clarify that, giving one
> simple example and pointing users to the correct 802.1Q section for
> further clarifications if needed.
> 
> Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
> ---
>  man/man8/tc-cbs.8 | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/man/man8/tc-cbs.8 b/man/man8/tc-cbs.8
> index 97e00c84..32e1e0d4 100644
> --- a/man/man8/tc-cbs.8
> +++ b/man/man8/tc-cbs.8
> @@ -43,7 +43,19 @@ second) when there is at least one packet waiting for transmission.
>  Packets are transmitted when the current value of credits is equal or
>  greater than zero. When there is no packet to be transmitted the
>  amount of credits is set to zero. This is the main tunable of the CBS
> -algorithm.
> +algorithm and represents the bandwidth that will be consumed.
> +Note that when calculating idleslope, the entire packet size must be
> +considered, including headers from all layers (i.e. MAC framing and any
> +overhead from the physical layer), as described by IEEE 802.1Q-2014
> +section 34.4.
> +
> +As an example, for an ethernet frame carrying 284 bytes of payload,
> +and with no VLAN tags, you must add 14 bytes for the Ethernet headers,
> +4 bytes for the Frame check sequence (CRC), and 20 bytes for the L1
> +overhead: 12 bytes of interpacket gap, 7 bytes of preamble and 1 byte
> +of start of frame delimiter. That results in 322 bytes for the total
> +packet size, which is then used for calculating the idleslope.
> +
>  .TP
>  sendslope
>  Sendslope is the rate of credits that is depleted (it should be a

Applied to net-next

      reply	other threads:[~2017-11-12 23:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10 22:34 [PATCH iproute2] man: Clarify idleslope calculation for tc-cbs Jesus Sanchez-Palencia
2017-11-12 23:58 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171112155845.69a079ae@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=andre.guedes@intel.com \
    --cc=ivan.briano@intel.com \
    --cc=jesus.sanchez-palencia@intel.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=vinicius.gomes@intel.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).