From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 2/2] devlink: add batch command support Date: Sun, 12 Nov 2017 16:16:50 -0800 Message-ID: <20171112161650.355a927f@xeon-e3> References: <20171110062014.2693-1-ivecera@redhat.com> <20171110062014.2693-3-ivecera@redhat.com> <20171110065727.GM18825@mtr-leonro.local> <3c672b8b-d3ca-1d50-c4e1-78a36aae6ed7@redhat.com> <20171110194735.GN18825@mtr-leonro.local> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/oASu5QR_FxRt7/dbiPa_Far"; protocol="application/pgp-signature" Cc: Ivan Vecera , netdev@vger.kernel.org, jiri@mellanox.com, arkadis@mellanox.com To: Leon Romanovsky Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:43288 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750948AbdKMAQx (ORCPT ); Sun, 12 Nov 2017 19:16:53 -0500 Received: by mail-pf0-f195.google.com with SMTP id a84so5719143pfl.0 for ; Sun, 12 Nov 2017 16:16:53 -0800 (PST) In-Reply-To: <20171110194735.GN18825@mtr-leonro.local> Sender: netdev-owner@vger.kernel.org List-ID: --Sig_/oASu5QR_FxRt7/dbiPa_Far Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 10 Nov 2017 21:47:35 +0200 Leon Romanovsky wrote: > On Fri, Nov 10, 2017 at 08:10:43AM +0100, Ivan Vecera wrote: > > On 10.11.2017 07:57, Leon Romanovsky wrote: =20 > > > On Fri, Nov 10, 2017 at 07:20:14AM +0100, Ivan Vecera wrote: =20 > > >> The patch adds support to batch devlink commands. > > >> > > >> Cc: Jiri Pirko > > >> Cc: Arkadi Sharshevsky > > >> Signed-off-by: Ivan Vecera > > >> --- > > >> devlink/devlink.c | 70 +++++++++++++++++++++++++++++++++++++++++++= ++++------- > > >> man/man8/devlink.8 | 16 +++++++++++++ > > >> 2 files changed, 78 insertions(+), 8 deletions(-) > > >> =20 > > > > > > <..> > > > =20 > > >> diff --git a/man/man8/devlink.8 b/man/man8/devlink.8 > > >> index a480766c..a975ef34 100644 > > >> --- a/man/man8/devlink.8 > > >> +++ b/man/man8/devlink.8 > > >> @@ -12,6 +12,12 @@ devlink \- Devlink tool > > >> .sp > > >> > > >> .ti -8 > > >> +.B devlink > > >> +.RB "[ " -force " ] " > > >> +.BI "-batch " filename > > >> +.sp > > >> + > > >> +.ti -8 > > >> .IR OBJECT " :=3D { " > > >> .BR dev " | " port " | " monitor " }" > > >> .sp > > >> @@ -32,6 +38,16 @@ Print the version of the > > >> utility and exit. > > >> > > >> .TP > > >> +.BR "\-b", " \-batch " > > >> +Read commands from provided file or standard input and invoke them. > > >> +First failure will cause termination of devlink. =20 > > > > > > It is worth to document the expected format of that file. > > > And IMHO, it is better to have ability to load JSON fie which was > > > generated by -j, instead of declaring new format/knob. =20 > > It's just a list of command-lines... like other utils (bridge,ip...) =20 >=20 > I'm implementing similar thing in RDMAtool (part of iproute2) and choose = JSON > approach, it is more user and script friendly. >=20 If you want to do batch form rdmatool then it must take list of commands by= default. An additional option to take json input "rdmatool -j --batch..." would be g= ood as well. --Sig_/oASu5QR_FxRt7/dbiPa_Far Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEn2/DRbBb5+dmuDyPgKd/YJXN5H4FAloI5HIACgkQgKd/YJXN 5H4xfA//Q7sBYK2dUd6HdsIZlsuP+e+NyF07AmmtBRUvcfvgsO8MVpX5w9ugkIjw uiDTowo0ATQoXLcf6Zi2ezIvlap6k1Znj8lyu1l20Ob2m/8EogmA75QE7nqYESZ+ TdrXpWTuLbvBxAJtBRjwdK5F3xEw3zxlFEDn+JtshcGtFWEH/DOigd1GV2Xss0Pu UvmQE4R7/Wd8emWGI5ivPvZwjpGzKpdqZGiZ2WAXZ+Diwnjb363yzhN9GILiBeMR 6lMek9ntzXd2ADcAmTGLXeP9wNcW9AOXkkO7IvWzXQ+wfao75Nqn09GxXc6nWRwd v5SVammPswGNXyU6dsVY9lBq0AOgJ533rQzFVYMP8P+XjYRrgDcnbNaKuM5IngeW QjlLt7ABukQ1lpxLQBJQcKBjqxANDZZZ3BAKkgNyzsI5nkTd6S2Dy5UIgFiWbpCY k3wWun/E85JH2VPEUy8NiOIWhDbWuaI2hjBMg5ZPPCOBqZ1JYzqiOuHOW9cat2z7 8nhHJubL3/3LSe0W+V5wRgnUFKq9u7DKW9aM/Byq6K8utQlIVOhUOB/+77xjgtha 0vkm0LlsijP5AOqkVc5kBnK0w45Rk1DbxUX6byo96nZi5adbXGYKwnaPgXB2GuyA RHHRhhAu6gYNhsqA/thOEG+5BDpxqC3jQ47iAhnVr6hkiVxhG1I= =kTIQ -----END PGP SIGNATURE----- --Sig_/oASu5QR_FxRt7/dbiPa_Far--