From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [patch net-next v2 01/10] cls_bpf: move prog offload->netdev check into drivers Date: Sun, 12 Nov 2017 18:14:18 -0800 Message-ID: <20171112181418.3ca6ff54@cakuba> References: <20171112155604.24061-1-jiri@resnulli.us> <20171112155604.24061-2-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, ast@kernel.org, daniel@iogearbox.net, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com To: Jiri Pirko Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:54090 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbdKMCOV (ORCPT ); Sun, 12 Nov 2017 21:14:21 -0500 Received: by mail-pf0-f193.google.com with SMTP id b6so10545317pff.10 for ; Sun, 12 Nov 2017 18:14:21 -0800 (PST) In-Reply-To: <20171112155604.24061-2-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 12 Nov 2017 16:55:55 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > In order to remove tp->q usage in cls_bpf, the offload->netdev check > needs to be moved to individual drivers as only they will have access > to appropriate struct net_device. > > Signed-off-by: Jiri Pirko This seems not entirely correct and it adds unnecessary code. I think the XDP and cls_bpf handling could be unified, making way for binding the same program to multiple ports of the same device. Would you mind waiting a day for me to send corrections to BPF offload?