From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [patch net-next v2 01/10] cls_bpf: move prog offload->netdev check into drivers Date: Sun, 12 Nov 2017 23:17:34 -0800 Message-ID: <20171112231734.57e651d4@cakuba> References: <20171112155604.24061-1-jiri@resnulli.us> <20171112155604.24061-2-jiri@resnulli.us> <20171112181418.3ca6ff54@cakuba> <20171113062538.GA1986@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, ast@kernel.org, daniel@iogearbox.net, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com To: Jiri Pirko Return-path: Received: from mail-it0-f42.google.com ([209.85.214.42]:40726 "EHLO mail-it0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbdKMHRj (ORCPT ); Mon, 13 Nov 2017 02:17:39 -0500 Received: by mail-it0-f42.google.com with SMTP id 72so8220010itl.5 for ; Sun, 12 Nov 2017 23:17:39 -0800 (PST) In-Reply-To: <20171113062538.GA1986@nanopsycho> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 13 Nov 2017 07:25:38 +0100, Jiri Pirko wrote: > Mon, Nov 13, 2017 at 03:14:18AM CET, jakub.kicinski@netronome.com wrote: > >On Sun, 12 Nov 2017 16:55:55 +0100, Jiri Pirko wrote: =20 > >> From: Jiri Pirko > >>=20 > >> In order to remove tp->q usage in cls_bpf, the offload->netdev check > >> needs to be moved to individual drivers as only they will have access > >> to appropriate struct net_device. > >>=20 > >> Signed-off-by: Jiri Pirko =20 > > > >This seems not entirely correct and it adds unnecessary code. I think = =20 >=20 > What is not correct? =46rom quick reading it looks like you will allow to install the dev-specific filter without skip_sw flag. You haven't fixed what your previous series broke in cls_bpf offload model and now you=20 break it even further. > >the XDP and cls_bpf handling could be unified, making way for binding > >the same program to multiple ports of the same device. Would you mind > >waiting a day for me to send corrections to BPF offload? =20 >=20 > Well I'm trying to get this in before net-next closes... Right, and I'm surprised by that. I'd hope you'll understand my caution here given recent history.