From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [patch net-next v2 06/10] net: sched: allow ingress and clsact qdiscs to share filter blocks Date: Sun, 12 Nov 2017 23:54:52 -0800 Message-ID: <20171112235452.164efa55@cakuba> References: <20171112155604.24061-1-jiri@resnulli.us> <20171112155604.24061-7-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, ast@kernel.org, daniel@iogearbox.net, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com To: Jiri Pirko Return-path: Received: from mail-it0-f65.google.com ([209.85.214.65]:39365 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbdKMHy4 (ORCPT ); Mon, 13 Nov 2017 02:54:56 -0500 Received: by mail-it0-f65.google.com with SMTP id y15so8327386ita.4 for ; Sun, 12 Nov 2017 23:54:56 -0800 (PST) In-Reply-To: <20171112155604.24061-7-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 12 Nov 2017 16:56:00 +0100, Jiri Pirko wrote: > diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c > index 5ecc38f..ee89efc 100644 > --- a/net/sched/sch_ingress.c > +++ b/net/sched/sch_ingress.c > @@ -60,6 +60,29 @@ static void clsact_chain_head_change(struct tcf_proto *tp_head, void *priv) > struct mini_Qdisc_pair *miniqp = priv; > > mini_qdisc_pair_swap(miniqp, tp_head); > +}; > + > +static const struct nla_policy ingress_policy[TCA_CLSACT_MAX + 1] = { > + [TCA_CLSACT_INGRESS_BLOCK] = { .type = NLA_U32 }, > +}; > + > +static int ingress_parse_opt(struct nlattr *opt, u32 *p_ingress_block_index) nit: why the p_ prefix on all the pointers?