From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] ip_gre: fix ip-config error reported by lkp-robot Date: Mon, 13 Nov 2017 09:58:23 +0900 (KST) Message-ID: <20171113.095823.1390842591777079522.davem@davemloft.net> References: <1510070264-56415-1-git-send-email-u9012063@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: u9012063@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:45550 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbdKMA61 (ORCPT ); Sun, 12 Nov 2017 19:58:27 -0500 In-Reply-To: <1510070264-56415-1-git-send-email-u9012063@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: William Tu Date: Tue, 7 Nov 2017 07:57:44 -0800 > lkp-robot reports the following two errors: > IP-Config: Failed to open gretap0 > IP-Config: Failed to open erspan0 > due to device's mac address is zero. Fix it by assigning > a random Ethernet address. > > Signed-off-by: William Tu This isn't really a good idea. If there is a tunnel source address of zero, which is where the device address comes from, we shouldn't allow the interface to come up because it is misconfigured.