From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: realtek: r8169: remove redundant assignment to giga_ctrl Date: Mon, 13 Nov 2017 10:08:53 +0900 (KST) Message-ID: <20171113.100853.145554446239802065.davem@davemloft.net> References: <20171108132323.26292-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: nic_swsd@realtek.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: colin.king@canonical.com Return-path: In-Reply-To: <20171108132323.26292-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin King Date: Wed, 8 Nov 2017 13:23:23 +0000 > From: Colin Ian King > > The variable giga_ctrl is being assigned to zero however this is > never read and hence the assignment is redundant, so remove it. > Cleans up clang warning: > > drivers/net/ethernet/realtek/r8169.c:1978:3: warning: Value stored > to 'giga_ctrl' is never read > > Signed-off-by: Colin Ian King Applied, thanks Colin.