From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH net-next 2/8] rtnetlink: add rtnl_register_module
Date: Mon, 13 Nov 2017 08:55:15 +0100
Message-ID: <20171113075515.ltphkflhq4uk3rwe@hirez.programming.kicks-ass.net>
References: <20171106105113.20476-1-fw@strlen.de>
 <20171106105113.20476-3-fw@strlen.de>
 <20171106124454.GI3165@worktop.lehotels.local>
 <20171107061156.GK9424@breakpoint.cc>
 <20171107091004.GI3326@worktop>
 <20171107092458.GF3857@worktop>
 <20171107094751.GM9424@breakpoint.cc>
 <20171107145736.GN3165@worktop.lehotels.local>
 <20171113072159.GN5512@breakpoint.cc>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org
To: Florian Westphal <fw@strlen.de>
Return-path: <netdev-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([65.50.211.133]:52535 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751585AbdKMHzS (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 13 Nov 2017 02:55:18 -0500
Content-Disposition: inline
In-Reply-To: <20171113072159.GN5512@breakpoint.cc>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Nov 13, 2017 at 08:21:59AM +0100, Florian Westphal wrote:
> Reason is that some places do this:
> 
> rtnl_register(pf, RTM_FOO, doit, NULL, 0);
> rtnl_register(pf, RTM_FOO, NULL, dumpit, 0);

Sure, however,

> (from different call sites in the stack).
> > -	if (doit)
> > -		tab[msgindex].doit = doit;
> > -	if (dumpit)
> > -		tab[msgindex].dumpit = dumpit;
> 
> Which is the reason for these if () tests.

then we assign NULL, which is fine, no?