From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v2 01/10] cls_bpf: move prog offload->netdev check into drivers Date: Mon, 13 Nov 2017 08:55:56 +0100 Message-ID: <20171113075556.GD1986@nanopsycho> References: <20171112155604.24061-1-jiri@resnulli.us> <20171112155604.24061-2-jiri@resnulli.us> <20171112181418.3ca6ff54@cakuba> <20171113062538.GA1986@nanopsycho> <20171112231734.57e651d4@cakuba> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, ast@kernel.org, daniel@iogearbox.net, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com To: Jakub Kicinski Return-path: Received: from mail-wm0-f43.google.com ([74.125.82.43]:52359 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887AbdKMHz6 (ORCPT ); Mon, 13 Nov 2017 02:55:58 -0500 Received: by mail-wm0-f43.google.com with SMTP id t139so13153968wmt.1 for ; Sun, 12 Nov 2017 23:55:58 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171112231734.57e651d4@cakuba> Sender: netdev-owner@vger.kernel.org List-ID: Mon, Nov 13, 2017 at 08:17:34AM CET, jakub.kicinski@netronome.com wrote: >On Mon, 13 Nov 2017 07:25:38 +0100, Jiri Pirko wrote: >> Mon, Nov 13, 2017 at 03:14:18AM CET, jakub.kicinski@netronome.com wrote: >> >On Sun, 12 Nov 2017 16:55:55 +0100, Jiri Pirko wrote: >> >> From: Jiri Pirko >> >> >> >> In order to remove tp->q usage in cls_bpf, the offload->netdev check >> >> needs to be moved to individual drivers as only they will have access >> >> to appropriate struct net_device. >> >> >> >> Signed-off-by: Jiri Pirko >> > >> >This seems not entirely correct and it adds unnecessary code. I think >> >> What is not correct? > >>From quick reading it looks like you will allow to install the >dev-specific filter without skip_sw flag. You haven't fixed what Right. I see it now. >your previous series broke in cls_bpf offload model and now you What do you mean exactly? >break it even further. > >> >the XDP and cls_bpf handling could be unified, making way for binding >> >the same program to multiple ports of the same device. Would you mind >> >waiting a day for me to send corrections to BPF offload? >> >> Well I'm trying to get this in before net-next closes... > >Right, and I'm surprised by that. I'd hope you'll understand my caution >here given recent history. Sure.