From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v2 06/10] net: sched: allow ingress and clsact qdiscs to share filter blocks Date: Mon, 13 Nov 2017 08:56:58 +0100 Message-ID: <20171113075658.GE1986@nanopsycho> References: <20171112155604.24061-1-jiri@resnulli.us> <20171112155604.24061-7-jiri@resnulli.us> <20171112235452.164efa55@cakuba> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, ast@kernel.org, daniel@iogearbox.net, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com To: Jakub Kicinski Return-path: Received: from mail-wr0-f196.google.com ([209.85.128.196]:48965 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbdKMH5A (ORCPT ); Mon, 13 Nov 2017 02:57:00 -0500 Received: by mail-wr0-f196.google.com with SMTP id 15so13581660wrb.5 for ; Sun, 12 Nov 2017 23:57:00 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171112235452.164efa55@cakuba> Sender: netdev-owner@vger.kernel.org List-ID: Mon, Nov 13, 2017 at 08:54:52AM CET, jakub.kicinski@netronome.com wrote: >On Sun, 12 Nov 2017 16:56:00 +0100, Jiri Pirko wrote: >> diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c >> index 5ecc38f..ee89efc 100644 >> --- a/net/sched/sch_ingress.c >> +++ b/net/sched/sch_ingress.c >> @@ -60,6 +60,29 @@ static void clsact_chain_head_change(struct tcf_proto *tp_head, void *priv) >> struct mini_Qdisc_pair *miniqp = priv; >> >> mini_qdisc_pair_swap(miniqp, tp_head); >> +}; >> + >> +static const struct nla_policy ingress_policy[TCA_CLSACT_MAX + 1] = { >> + [TCA_CLSACT_INGRESS_BLOCK] = { .type = NLA_U32 }, >> +}; >> + >> +static int ingress_parse_opt(struct nlattr *opt, u32 *p_ingress_block_index) > >nit: why the p_ prefix on all the pointers? Just to diferenciate: u32 *ingress_block_index and u32 ingress_block_index