From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v2 04/10] net: sched: introduce block mechanism to handle netif_keep_dst calls Date: Mon, 13 Nov 2017 08:58:44 +0100 Message-ID: <20171113075844.GF1986@nanopsycho> References: <20171112155604.24061-1-jiri@resnulli.us> <20171112155604.24061-5-jiri@resnulli.us> <20171112234726.67211d6a@cakuba> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, ast@kernel.org, daniel@iogearbox.net, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com To: Jakub Kicinski Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:55171 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbdKMH6q (ORCPT ); Mon, 13 Nov 2017 02:58:46 -0500 Received: by mail-wm0-f67.google.com with SMTP id r68so13171342wmr.3 for ; Sun, 12 Nov 2017 23:58:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171112234726.67211d6a@cakuba> Sender: netdev-owner@vger.kernel.org List-ID: Mon, Nov 13, 2017 at 08:47:26AM CET, jakub.kicinski@netronome.com wrote: >On Sun, 12 Nov 2017 16:55:58 +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Couple of classifiers call netif_keep_dst directly on q->dev. That is >> not possible to do directly for shared blocke where multiple qdiscs are >> owning the block. So introduce a infrastructure to keep track of the >> block owners in list and use this list to implement block variant of >> netif_keep_dst. >> >> Signed-off-by: Jiri Pirko > >Could you use the list you add here to check the ethtool tc offload >flag? :) It is a list of qdisc sub parts. Not a list of netdevs