From: Stephen Hemminger <stephen@networkplumber.org>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
eric.dumazet@gmail.com, netdev@vger.kernel.org,
haiyangz@microsoft.com, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, David Miller <davem@davemloft.net>
Subject: Re: [RFC] hv_netvsc: safer orderly shutdown
Date: Mon, 13 Nov 2017 09:22:53 -0800 [thread overview]
Message-ID: <20171113092253.68dd8ae1@xeon-e3> (raw)
In-Reply-To: <87ineebg44.fsf@vitty.brq.redhat.com>
On Mon, 13 Nov 2017 11:57:47 +0100
Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
> Stephen Hemminger <stephen@networkplumber.org> writes:
>
> >
> > The NAPI disable is already handled by rndis close.
>
> Sorry, but I'm probably missing something: I can only see
> netif_napi_del() call in netvsc_device_remove() but this happens much
> later. And I don see us doing napi_disable() anywhere on the path.
> But I'm probably missing something.
>
You need to keep NAPI running to handle transmit completions.
Disabling the Tx and Rx filter should keep spurious activity
away until the halt is done.
prev parent reply other threads:[~2017-11-13 17:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 10:35 [PATCH net-next v2 0/2] hv_netvsc: fix a hang on channel/mtu changes Vitaly Kuznetsov
2017-11-02 10:35 ` [PATCH net-next v2 1/2] hv_netvsc: netvsc_teardown_gpadl() split Vitaly Kuznetsov
2017-11-02 10:35 ` [PATCH net-next v2 2/2] hv_netvsc: hide warnings about uninitialized/missing rndis device Vitaly Kuznetsov
[not found] ` <CAOaVG14eqAq8irLbgR9b-JA--aiTov=VWZpTi2maKQ=nbo_ByQ@mail.gmail.com>
[not found] ` <CAOaVG16ekV3rP4dA3GgnAcodPuALXd4W5eTtjNr_Pwtn3JVkxQ@mail.gmail.com>
[not found] ` <CAOaVG17ctoE53UkBG4O1=962K4qOzAjteEeG6uiNDgCUGq4jYQ@mail.gmail.com>
2017-11-08 9:36 ` Vitaly Kuznetsov
2017-11-08 1:31 ` [PATCH net-next v2 0/2] hv_netvsc: fix a hang on channel/mtu changes David Miller
2017-11-10 3:53 ` [RFC] hv_netvsc: safer orderly shutdown Stephen Hemminger
2017-11-10 10:42 ` Vitaly Kuznetsov
[not found] ` <CAOaVG15dBsPcpi1buaKyW5oRGmGUczgaO54De6eYXUqp-1z+gw@mail.gmail.com>
2017-11-13 10:57 ` Vitaly Kuznetsov
2017-11-13 17:22 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113092253.68dd8ae1@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=eric.dumazet@gmail.com \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).