From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 2/2] net: dsa: lan9303: Clear offload_fwd_mark
 for IGMP
Date: Mon, 13 Nov 2017 14:02:27 +0100
Message-ID: <20171113130227.GC22473@lunn.ch>
References: <20171110115435.4261-1-privat@egil-hjelmeland.no>
 <20171110115435.4261-3-privat@egil-hjelmeland.no>
 <2e0d170e-08f6-4009-e422-6faea463a0c2@egil-hjelmeland.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
To: Egil Hjelmeland <privat@egil-hjelmeland.no>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:53762 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754891AbdKMNCf (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 13 Nov 2017 08:02:35 -0500
Content-Disposition: inline
In-Reply-To: <2e0d170e-08f6-4009-e422-6faea463a0c2@egil-hjelmeland.no>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> RTFM, my bad. The lan9303 has both STP and IGMP bits in the receive tag. It
> is as simple as:
> 
> u16 lan9303_tag1 = ntohs(lan9303_tag[1]);
> skb->offload_fwd_mark = !(lan9303_tag1 & 0x18);

Hi Egil

That is much nicer. But please add a couple of #defines for the 0x18
bits.

	Andrew