From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH net] ipv6: set all.accept_dad to 0 by default
Date: Mon, 13 Nov 2017 15:32:14 +0100
Message-ID: <20171113153214.33019580@elisabeth>
References: <20171113134536.15382-1-nicolas.dichtel@6wind.com>
        <CAAedzxo9qo+=0=fEhf1zz=w_CSniim+nBW6uLxthOCLV9GbMvQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>,
        David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        Matteo Croce <mcroce@redhat.com>,
        Maciej =?UTF-8?B?xbtlbmN6eWtvd3NraQ==?= <maze@google.com>
To: Erik Kline <ek@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:59780 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751174AbdKMOcY (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 13 Nov 2017 09:32:24 -0500
In-Reply-To: <CAAedzxo9qo+=0=fEhf1zz=w_CSniim+nBW6uLxthOCLV9GbMvQ@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 13 Nov 2017 14:21:52 +0000
Erik Kline <ek@google.com> wrote:

> Should we consider rolling back the patch that caused this?
> "accept_dad = 1" is the proper IETF-expected default behaviour.
> 
> Alternatively, if we really want to make all, default, and ifname
> useful perhaps we need to investigate a tristate option (for currently
> boolean values, at least).  -1 could mean no preference, for example.

I haven't checked how ugly it would be, yet. But another way to restore
the previous behaviour, while keeping the new functionality, would be
to keep the global default as 1 and instead set the per-interface
accept_dad default value to 0. What do you think?

-- 
Stefano