netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Erik Kline <ek@google.com>
Cc: "Nicolas Dichtel" <nicolas.dichtel@6wind.com>,
	"David Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	"Matteo Croce" <mcroce@redhat.com>,
	"Maciej Żenczykowski" <maze@google.com>
Subject: Re: [PATCH net] ipv6: set all.accept_dad to 0 by default
Date: Tue, 14 Nov 2017 03:42:09 +0100	[thread overview]
Message-ID: <20171114034209.4fddc3f2@elisabeth> (raw)
In-Reply-To: <CAAedzxo9qo+=0=fEhf1zz=w_CSniim+nBW6uLxthOCLV9GbMvQ@mail.gmail.com>

On Mon, 13 Nov 2017 14:21:52 +0000
Erik Kline <ek@google.com> wrote:

> Alternatively, if we really want to make all, default, and ifname
> useful perhaps we need to investigate a tristate option (for currently
> boolean values, at least).  -1 could mean no preference, for example.

I think this would make sense in general, but on the other hand it
would be quite a big change, and Nicolas' patch has the advantages of
being small, keeping the global flag functional, and restoring the
previous default behaviour out of the box when 'accept_dad' is disabled
by the user for a given interface.

Besides, this still wouldn't solve the case where flags are >= 0 and
conflicting -- there, it's still debatable whether we want a logical
OR or a logical AND.

In the end, I would prefer either Nicolas' patch, or to get rid of the
global 'accept_dad' flag altogether. Having a flag which does
absolutely nothing, which was the case before 35e015e1f577, doesn't
sound correct by any means.

-- 
Stefano

  parent reply	other threads:[~2017-11-14  2:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 13:45 [PATCH net] ipv6: set all.accept_dad to 0 by default Nicolas Dichtel
2017-11-13 14:21 ` Erik Kline
2017-11-13 14:28   ` Matteo Croce
2017-11-13 14:32   ` Stefano Brivio
2017-11-13 14:52     ` Maciej Żenczykowski
2017-11-13 15:05       ` Stefano Brivio
2017-11-13 16:09         ` Nicolas Dichtel
2017-11-14  2:42   ` Stefano Brivio [this message]
2017-11-14  2:24 ` Stefano Brivio
2017-11-14  9:43   ` Nicolas Dichtel
2017-11-14 13:21   ` [PATCH net v2] " Nicolas Dichtel
2017-11-14 13:53     ` Stefano Brivio
2017-11-14 18:30     ` Girish Moodalbail
2017-11-14 19:10       ` Stefano Brivio
2017-11-14 20:52         ` Girish Moodalbail
2017-11-15 10:17     ` Nicolas Dichtel
2017-11-15 10:25       ` David Miller
2017-11-15 10:49         ` Nicolas Dichtel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171114034209.4fddc3f2@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=davem@davemloft.net \
    --cc=ek@google.com \
    --cc=maze@google.com \
    --cc=mcroce@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).