From: Jiri Pirko <jiri@resnulli.us>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Jamal Hadi Salim <jhs@mojatatu.com>,
mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>,
Eric Dumazet <edumazet@google.com>,
Willem de Bruijn <willemb@google.com>, tcharding <me@tobin.cc>,
John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [patch net] net: forbid netdev used by mirred tc act from being moved to another netns
Date: Tue, 14 Nov 2017 06:17:52 +0100 [thread overview]
Message-ID: <20171114051752.GA1890@nanopsycho> (raw)
In-Reply-To: <CAM_iQpXVmPnvMNYmY1n1TknCHakOqj8Xt56CDtcaumLaOuT0Sw@mail.gmail.com>
Mon, Nov 13, 2017 at 08:53:57PM CET, xiyou.wangcong@gmail.com wrote:
>On Mon, Nov 13, 2017 at 6:05 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> Currently, user may choose to move device that is used by mirred action
>> to another network namespace. That is wrong as the action still remains
>> in the original namespace and references non-existing ifindex.
>
>It is a pure display issue, the action itself should function well
>because we only use ifindex to lookup netdevice once and
>we save the netdevice pointer in action.
>
>If you really want to fix it, just tell iprout2 to display netnsid together
>with ifindex.
It is not only display issue. I think it is wrong to let a netdevice
dissapear from underneath the mirred action. You certainly cannot add an
action mirred with device from another net namespace. So should we allow
that?
next prev parent reply other threads:[~2017-11-14 5:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 14:05 [patch net] net: forbid netdev used by mirred tc act from being moved to another netns Jiri Pirko
2017-11-13 17:37 ` David Ahern
2017-11-13 19:53 ` Cong Wang
2017-11-14 5:17 ` Jiri Pirko [this message]
2017-11-14 5:51 ` Cong Wang
2017-11-14 6:35 ` Jiri Pirko
2017-11-14 18:53 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114051752.GA1890@nanopsycho \
--to=jiri@resnulli.us \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=john.fastabend@gmail.com \
--cc=me@tobin.cc \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).