From: Ahmed Abdelsalam <amsalam20@gmail.com>
To: Edward Cree <ecree@solarflare.com>
Cc: David Miller <davem@davemloft.net>, <david.lebrun@uclouvain.be>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH] ipv6: sr: update the struct ipv6_sr_hdr
Date: Tue, 14 Nov 2017 15:31:48 +0100 [thread overview]
Message-ID: <20171114153148.7f43787fb8cc9fe7a7dcb4fc@gmail.com> (raw)
In-Reply-To: <1a10815f-8830-e71b-a323-36566befc99a@solarflare.com>
On Tue, 14 Nov 2017 14:14:01 +0000
Edward Cree <ecree@solarflare.com> wrote:
> On 14/11/17 12:37, David Miller wrote:
> > From: Ahmed Abdelsalam <amsalam20@gmail.com>
> > Date: Sun, 12 Nov 2017 21:37:01 +0100
> >
> >> diff --git a/include/uapi/linux/seg6.h b/include/uapi/linux/seg6.h
> >> index 2f6fb0d..3f4b3ab 100644
> >> --- a/include/uapi/linux/seg6.h
> >> +++ b/include/uapi/linux/seg6.h
> >> @@ -26,9 +26,9 @@ struct ipv6_sr_hdr {
> >> __u8 hdrlen;
> >> __u8 type;
> >> __u8 segments_left;
> >> - __u8 first_segment;
> >> + __u8 last_entry;
> >
> > This is user ABI and cannot be changed.
> >
> > Sorry, folks should have considered these issues when the SR
> > changes were submitted. This field must keep the name 'first_segment'
> > forever.
>
> Surely renaming struct fields only changes the API, not the ABI?
> Binaries compiled against the old struct definition will still behave the
> same (AFAICT the patch doesn't change how these fields are used), while
> sources being recompiled (so they care about the name change) can be
> changed.
Yes Exactly,
What I meant by the patch is to change just the field name, but the logic still the same.
Also it will not make sense to have the field name differnent from the draft.
--
Ahmed
next prev parent reply other threads:[~2017-11-14 14:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 20:37 [PATCH] ipv6: sr: update the struct ipv6_sr_hdr Ahmed Abdelsalam
2017-11-14 12:37 ` David Miller
2017-11-14 14:14 ` Edward Cree
2017-11-14 14:31 ` Ahmed Abdelsalam [this message]
2017-11-15 0:55 ` David Miller
2017-11-15 11:42 ` Ahmed Abdelsalam
2017-11-15 13:37 ` David Miller
2017-11-15 0:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114153148.7f43787fb8cc9fe7a7dcb4fc@gmail.com \
--to=amsalam20@gmail.com \
--cc=davem@davemloft.net \
--cc=david.lebrun@uclouvain.be \
--cc=ecree@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).