From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: Microchip KSZ* DSA drivers Re: [PATCH v1 RFC 1/1] Add Microchip KSZ8795 DSA driver Date: Tue, 14 Nov 2017 23:51:02 +0100 Message-ID: <20171114225101.GA29650@amd> References: <1507322023-15182-1-git-send-email-Tristram.Ha@microchip.com> <1507322023-15182-2-git-send-email-Tristram.Ha@microchip.com> <20171011205916.GC31288@amd> <93AF473E2DA327428DE3D46B72B1E9FD41131990@CHN-SV-EXMX02.mchp-main.com> <20171112222806.GA16781@amd> <93AF473E2DA327428DE3D46B72B1E9FD41138B54@CHN-SV-EXMX02.mchp-main.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sdtB3X0nJg68CQEu" Cc: andrew@lunn.ch, f.fainelli@gmail.com, ruediger.schmitt@philips.com, muvarov@gmail.com, nathan.leigh.conrad@gmail.com, vivien.didelot@savoirfairelinux.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Tristram.Ha@microchip.com Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:42749 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756900AbdKNWvE (ORCPT ); Tue, 14 Nov 2017 17:51:04 -0500 Content-Disposition: inline In-Reply-To: <93AF473E2DA327428DE3D46B72B1E9FD41138B54@CHN-SV-EXMX02.mchp-main.com> Sender: netdev-owner@vger.kernel.org List-ID: --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2017-11-14 01:49:47, Tristram.Ha@microchip.com wrote: > > Subject: Microchip KSZ* DSA drivers Re: [PATCH v1 RFC 1/1] Add Microchip > > KSZ8795 DSA driver > >=20 > > Hi! > >=20 > > Are there any news here? Is there new release planned? Is there a git > > tree somewhere? I probably should get it working, soon.. so I guess I > > can help with testing. > >=20 >=20 > Reviewed patches will be submitted formally to net-next within this week. >=20 > BTW, how is the KSZ8895 driver working for you? Are there some issues th= at > prevent you from using it? I tried patching it, but it seems I did not have all the neccessary pieces, so I did not get it to build. KSZ8895 seemed to depend on all the other drivers and I probably missed a patch somewhere. I have these in my tree: commit 6262f8173a21eec96f6b600adf5b9c7131e2c8d5 Author: Pavel Machek Date: Sun Oct 22 12:46:03 2017 +0200 From: Subject: [PATCH RFC] Add Microchip KSZ8895 DSA driver =20 From: Tristram Ha =20 Add Microchip KSZ8895 DSA driver. =20 Signed-off-by: Tristram Ha commit 4ea582e4b168b6413248ff587604c9fea6dc4f52 Author: Tristram Ha Date: Fri Oct 6 13:33:29 2017 -0700 Add other KSZ switch support so that patch check does not complain =20 Add other KSZ switch support so that patch check does not complain. =20 Signed-off-by: Tristram Ha commit 75d9e1a610590cb1f94b7ede3635360026fc4e57 Author: Tristram Ha Date: Fri Oct 6 13:33:05 2017 -0700 Modify tag_ksz.c so that tail tag code can be used by other KSZ switch = drivers =20 Modify tag_ksz.c so that tail tag code can be used by other KSZ switch drivers. =20 Signed-off-by: Tristram Ha commit 62efdaf5db7987e313846b82eef642404978cda7 Author: Tristram Ha Date: Fri Oct 6 13:33:04 2017 -0700 Add MIB counter reading support =20 Add MIB counter reading support. Rename ksz_9477_reg.h to ksz9477_reg.h for consistency as the product name is always KSZ####. Header file ksz_priv.h no longer contains any chip specific data. =20 Signed-off-by: Tristram Ha commit 5b29601cfa2c3032af560ae7ab10f55974e493fe Author: Tristram Ha Date: Fri Oct 6 13:33:03 2017 -0700 Break KSZ9477 DSA driver into two files =20 Break KSZ9477 DSA driver into two files in preparation to add more KSZ switch drivers. Add common functions in ksz_common.h so that other KSZ switch drivers can access code in ksz_common.c. Add ksz_spi.h for common functions used by KSZ switch SPI drivers. =20 Signed-off-by: Tristram Ha commit 02cb0a65cfe8434f93d9e16b0c65c86e5fe06870 Author: Tristram Ha Date: Fri Oct 6 13:33:02 2017 -0700 Rename ksz_spi.c to ksz9477_spi.c =20 Rename ksz_spi.c to ksz9477_spi.c and update Kconfig in preparation to = add more KSZ switch drivers. =20 Signed-off-by: Tristram Ha commit 0bc57b44d7d27fa7f7d682dd2222ed502d8682c6 Author: Tristram Ha Date: Fri Oct 6 13:33:01 2017 -0700 Rename some functions with ksz9477 prefix =20 Rename some functions with ksz9477 prefix to separate chip specific code from common code. =20 Signed-off-by: Tristram Ha commit 2d3f74e7dd923d5d0c9c2c01609297be1bc56b67 Author: Tristram Ha Date: Fri Oct 6 13:33:00 2017 -0700 Clean up code according to patch check suggestions =20 Clean up code according to patch check suggestions. =20 Signed-off-by: Tristram Ha commit d0e348b7b7938be2e91997c1dcdea185c8166b00 Author: Tristram Ha Date: Fri Oct 6 13:32:59 2017 -0700 Replace license with GPL =20 Replace license with GPL. =20 Signed-off-by: Tristram Ha commit d514cb5324feac3f6d8ede6649573f3c393f5e11 Author: Pavel Machek Date: Sun Oct 22 12:33:21 2017 +0200 Config for v4.14-rc5. =2E..and I guess I miss some KSZ8795 stuff: AR lib/built-in.o drivers/net/dsa/microchip/ksz8895.c: In function 'ksz8895_get_tag_protocol': drivers/net/dsa/microchip/ksz8895.c:633:9: error: 'DSA_TAG_PROTO_KSZ8795' undeclared (first use in this function) drivers/net/dsa/microchip/ksz8895.c:633:9: note: each undeclared identifier is reported only once for each function it appears in drivers/net/dsa/microchip/ksz8895.c:634:1: warning: control reaches end of non-void function [-Wreturn-type] If you had a git tree, or simply one big patch I could apply.. that would be welcome :-). Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --sdtB3X0nJg68CQEu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAloLc1UACgkQMOfwapXb+vLHNACfeV56OCr3mZ3n4RL1RbLf+JC3 c5MAn0SA6iflEqQiT8Kje5vXFe5z37fg =KmSK -----END PGP SIGNATURE----- --sdtB3X0nJg68CQEu--