From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com,
andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
f.fainelli@gmail.com, michael.chan@broadcom.com,
ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com,
leonro@mellanox.com, idosch@mellanox.com, ast@kernel.org,
daniel@iogearbox.net, simon.horman@netronome.com,
pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com,
alexander.h.duyck@intel.com, linville@tuxdriver.com,
gospo@broadcom.com, steven.lin1@broadcom.com,
yuvalm@mellanox.com, ogerlitz@mellanox.com,
dsa@cumulusnetworks.com, roopa@cumulusnetworks.com
Subject: Re: [patch net-next RFC v2 03/11] devlink: Add support for reload
Date: Wed, 15 Nov 2017 00:03:59 -0800 [thread overview]
Message-ID: <20171115000359.5a059580@cakuba> (raw)
In-Reply-To: <20171114161852.6633-4-jiri@resnulli.us>
On Tue, 14 Nov 2017 17:18:44 +0100, Jiri Pirko wrote:
> +static int devlink_nl_cmd_reload(struct sk_buff *skb, struct genl_info *info)
> +{
> + struct devlink *devlink = info->user_ptr[0];
> + int err;
> +
> + if (!devlink->ops->reload)
> + return -EOPNOTSUPP;
> +
> + err = devlink_resources_validate(devlink, NULL, info);
> + if (err)
> + return err;
> +
> + mutex_unlock(&devlink->lock);
> + err = devlink->ops->reload(devlink);
> + mutex_lock(&devlink->lock);
> +
> + return err;
> +}
I'm a bit confused with the locking, why is devlink->lock not held
around the validation?
next prev parent reply other threads:[~2017-11-15 8:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 16:18 [patch net-next RFC v2 00/11] Add support for resource abstraction Jiri Pirko
2017-11-14 16:18 ` [patch net-next RFC v2 01/11] devlink: Add per devlink instance lock Jiri Pirko
2017-11-14 16:18 ` [patch net-next RFC v2 02/11] devlink: Add support for resource abstraction Jiri Pirko
2017-11-15 7:59 ` Jakub Kicinski
2017-11-15 11:27 ` Arkadi Sharshevsky
2017-11-18 18:34 ` David Ahern
2017-11-19 8:17 ` Arkadi Sharshevsky
2017-11-19 15:47 ` David Ahern
2017-11-23 12:25 ` Arkadi Sharshevsky
2017-11-27 16:08 ` David Ahern
2017-11-14 16:18 ` [patch net-next RFC v2 03/11] devlink: Add support for reload Jiri Pirko
2017-11-15 8:03 ` Jakub Kicinski [this message]
2017-11-15 8:14 ` Jiri Pirko
2017-11-15 11:33 ` Arkadi Sharshevsky
2017-11-14 16:18 ` [patch net-next RFC v2 04/11] devlink: Add relation between dpipe and resource Jiri Pirko
2017-11-18 19:06 ` David Ahern
2017-11-14 16:18 ` [patch net-next RFC v2 05/11] mlxsw: pci: Add support for performing bus reset Jiri Pirko
2017-11-14 16:18 ` [patch net-next RFC v2 06/11] mlxsw: spectrum: Add "spectrum" prefix macro Jiri Pirko
2017-11-14 16:18 ` [patch net-next RFC v2 07/11] mlxsw: spectrum: Register KVD resources with devlink Jiri Pirko
2017-11-15 0:15 ` David Ahern
2017-11-15 10:01 ` Arkadi Sharshevsky
2017-11-18 19:18 ` David Ahern
2017-11-19 8:44 ` Arkadi Sharshevsky
2017-11-14 16:18 ` [patch net-next RFC v2 08/11] mlxsw: spectrum_dpipe: Connect dpipe tables to resources Jiri Pirko
2017-11-18 19:19 ` David Ahern
2017-11-19 9:16 ` Arkadi Sharshevsky
2017-11-19 15:58 ` David Ahern
2017-11-23 13:40 ` Arkadi Sharshevsky
2017-11-27 16:12 ` David Ahern
2017-11-28 10:04 ` Arkadi Sharshevsky
2017-11-28 13:27 ` Jiri Pirko
2017-11-28 16:05 ` David Ahern
2017-11-14 16:18 ` [patch net-next RFC v2 09/11] mlxsw: spectrum: Add support for getting kvdl occupancy Jiri Pirko
2017-11-18 19:21 ` David Ahern
2017-11-19 9:17 ` Arkadi Sharshevsky
2017-11-14 16:18 ` [patch net-next RFC v2 10/11] mlxsw: pci: Add support for getting resource through devlink Jiri Pirko
2017-11-14 16:18 ` [patch net-next RFC v2 11/11] mlxsw: core: Add support for reload Jiri Pirko
2017-11-17 19:58 ` [patch net-next RFC v2 00/11] Add support for resource abstraction David Ahern
2017-11-19 7:56 ` Arkadi Sharshevsky
2017-11-18 19:56 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115000359.5a059580@cakuba \
--to=jakub.kicinski@netronome.com \
--cc=alexander.h.duyck@intel.com \
--cc=andrew@lunn.ch \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=f.fainelli@gmail.com \
--cc=ganeshgr@chelsio.com \
--cc=gospo@broadcom.com \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=john.hurley@netronome.com \
--cc=leonro@mellanox.com \
--cc=linville@tuxdriver.com \
--cc=matanb@mellanox.com \
--cc=michael.chan@broadcom.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=pieter.jansenvanvuuren@netronome.com \
--cc=roopa@cumulusnetworks.com \
--cc=saeedm@mellanox.com \
--cc=simon.horman@netronome.com \
--cc=steven.lin1@broadcom.com \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=yuvalm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).