From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Leech Subject: Re: [PATCH 0/9] use network namespace for iSCSI control interfaces Date: Tue, 14 Nov 2017 16:25:21 -0800 Message-ID: <20171115002521.GA21082@straylight.hirudinean.org> References: <20171107180156.GD29597@straylight.hirudinean.org> <20171107224513.4217-1-cleech@redhat.com> <063D6719AE5E284EB5DD2968C1650D6DD00B618E@AcuExch.aculab.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "netdev@vger.kernel.org" , "containers@lists.linux-foundation.org" To: David Laight Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50330 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbdKOAZZ (ORCPT ); Tue, 14 Nov 2017 19:25:25 -0500 Content-Disposition: inline In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD00B618E@AcuExch.aculab.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Nov 08, 2017 at 10:31:04AM +0000, David Laight wrote: > From: Chris Leech > > Sent: 07 November 2017 22:45 > > > > I've posted these changes to allow iSCSI management within a container > > using a network namespace to the SCSI and Open-iSCSI lists, but seeing > > as it's not really SCSI/block related I'm casting a wider net looking > > for reviews. > > I didn't spot you acquiring and releasing references to the namespace. > (I might have missed it, the relevant patch is difficult to read). > > If the sockets are created in the context of the process whose namespace > you are using you don't need it, but given the hooks and callbacks > I'm not at all sure that is obviously true. Thanks David, Looking at it again, you're right and I think I need to hold a reference for the iSCSI host and handle namespace deletion. Even for iscsi_tcp the socket gets handed off from the creating process to the transport and can outlive iscsid. I'm looking at migration or destruction now rather than later. Chris