[patch net-next 0/2] mlxsw: Update firmware version

[patch net-next 0/2] mlxsw: Update firmware version

[Jiri Pirko]

From: Jiri Pirko <jiri@mellanox.com>

Ido says:

This set adjusts the driver to use a new firmware version. The new
version includes various enhancements and fixes detailed in the first
patch.

The second patch enables batch deletion of neighbours on a router
interface (RIF) which was not possible with previous versions.

Ido Schimmel (1):
  mlxsw: spectrum_router: Add batch neighbour deletion

Shalom Toledo (1):
  mlxsw: spectrum: Update minimum firmware version to 13.1530.152

 drivers/net/ethernet/mellanox/mlxsw/spectrum.c        |  4 ++--
 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 15 ++++++++++++---
 2 files changed, 14 insertions(+), 5 deletions(-)

-- 
2.9.5

[patch net-next 1/2] mlxsw: spectrum: Update minimum firmware version to 13.1530.152

[Jiri Pirko]

From: Shalom Toledo <shalomt@mellanox.com>

This new firmware contains:
 - Support Spectrum A1 revision
 - Batch deletion of IPv6 neighbours
 - Remove incorrect VPD capability

Signed-off-by: Shalom Toledo <shalomt@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index b2cd1eb..2d46ec8 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -74,8 +74,8 @@
 #include "../mlxfw/mlxfw.h"
 
 #define MLXSW_FWREV_MAJOR 13
-#define MLXSW_FWREV_MINOR 1420
-#define MLXSW_FWREV_SUBMINOR 122
+#define MLXSW_FWREV_MINOR 1530
+#define MLXSW_FWREV_SUBMINOR 152
 
 static const struct mlxsw_fw_rev mlxsw_sp_supported_fw_rev = {
 	.major = MLXSW_FWREV_MAJOR,
-- 
2.9.5

[patch net-next 2/2] mlxsw: spectrum_router: Add batch neighbour deletion

[Jiri Pirko]

From: Ido Schimmel <idosch@mellanox.com>

In commit 4a3c67a6e7cd ("mlxsw: spectrum_router: Don't batch neighbour
deletion") I removed the support for batch deletion of neighbours on a
router interface (RIF) since at that time the firmware did not support
it for IPv6 neighbours.

This is now supported by the version enforced by the driver, so there is
no reason to delete neighbours one by one anymore.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index e918784..632c7b2 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -2416,16 +2416,25 @@ static void mlxsw_sp_neigh_fini(struct mlxsw_sp *mlxsw_sp)
 	rhashtable_destroy(&mlxsw_sp->router->neigh_ht);
 }
 
+static int mlxsw_sp_neigh_rif_flush(struct mlxsw_sp *mlxsw_sp,
+				    const struct mlxsw_sp_rif *rif)
+{
+	char rauht_pl[MLXSW_REG_RAUHT_LEN];
+
+	mlxsw_reg_rauht_pack(rauht_pl, MLXSW_REG_RAUHT_OP_WRITE_DELETE_ALL,
+			     rif->rif_index, rif->addr);
+	return mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(rauht), rauht_pl);
+}
+
 static void mlxsw_sp_neigh_rif_gone_sync(struct mlxsw_sp *mlxsw_sp,
 					 struct mlxsw_sp_rif *rif)
 {
 	struct mlxsw_sp_neigh_entry *neigh_entry, *tmp;
 
+	mlxsw_sp_neigh_rif_flush(mlxsw_sp, rif);
 	list_for_each_entry_safe(neigh_entry, tmp, &rif->neigh_list,
-				 rif_list_node) {
-		mlxsw_sp_neigh_entry_update(mlxsw_sp, neigh_entry, false);
+				 rif_list_node)
 		mlxsw_sp_neigh_entry_destroy(mlxsw_sp, neigh_entry);
-	}
 }
 
 enum mlxsw_sp_nexthop_type {
-- 
2.9.5

Re: [patch net-next 0/2] mlxsw: Update firmware version

[David Miller]

From: Jiri Pirko <jiri@resnulli.us>
Date: Sun, 12 Nov 2017 09:01:23 +0100

> From: Jiri Pirko <jiri@mellanox.com>
> 
> Ido says:
> 
> This set adjusts the driver to use a new firmware version. The new
> version includes various enhancements and fixes detailed in the first
> patch.
> 
> The second patch enables batch deletion of neighbours on a router
> interface (RIF) which was not possible with previous versions.

Series applied, thanks.

Re: [patch net-next 0/2] mlxsw: Update firmware version

[David Ahern]

On 11/14/17 5:17 AM, David Miller wrote:
> From: Jiri Pirko <jiri@resnulli.us>
> Date: Sun, 12 Nov 2017 09:01:23 +0100
> 
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> Ido says:
>>
>> This set adjusts the driver to use a new firmware version. The new
>> version includes various enhancements and fixes detailed in the first
>> patch.
>>
>> The second patch enables batch deletion of neighbours on a router
>> interface (RIF) which was not possible with previous versions.
> 
> Series applied, thanks.
> 

Can you wait until said firmware version has been pushed into
linux-firmware *before* sending these patches. Considering the driver
refuses to work without the right firmware version this has a negative
impact on users.

Re: [patch net-next 0/2] mlxsw: Update firmware version

[Ido Schimmel]

On Tue, Nov 14, 2017 at 05:59:36PM -0700, David Ahern wrote:
> Can you wait until said firmware version has been pushed into
> linux-firmware *before* sending these patches.

OK.

> Considering the driver refuses to work without the right firmware
> version this has a negative impact on users.

I'm aware of the consequences.