From: Ahmed Abdelsalam <amsalam20@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: ecree@solarflare.com, david.lebrun@uclouvain.be, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: sr: update the struct ipv6_sr_hdr
Date: Wed, 15 Nov 2017 12:42:02 +0100 [thread overview]
Message-ID: <20171115124202.bcb98eba1523e6957b34ccaf@gmail.com> (raw)
In-Reply-To: <20171115.095532.1032464049769067683.davem@davemloft.net>
On Wed, 15 Nov 2017 09:55:32 +0900 (KST)
David Miller <davem@davemloft.net> wrote:
> From: Ahmed Abdelsalam <amsalam20@gmail.com>
> Date: Tue, 14 Nov 2017 15:31:48 +0100
>
> > Also it will not make sense to have the field name differnent from the draft.
>
> That is the danger of defining user facing things against a draft which
> is constantly changing.
>
I totally understand your point of keeping the user API unchanged.
> Sorry, we are stuck with the current name.
For the time being, Can i submit another patch updating the "reserved" bits to be "tag" and just adding a comment next the "first_segment".
In the comment we can mention that this represent the "last_entry" field of the Segment Routing Header (SRH).
--
Ahmed
next prev parent reply other threads:[~2017-11-15 11:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 20:37 [PATCH] ipv6: sr: update the struct ipv6_sr_hdr Ahmed Abdelsalam
2017-11-14 12:37 ` David Miller
2017-11-14 14:14 ` Edward Cree
2017-11-14 14:31 ` Ahmed Abdelsalam
2017-11-15 0:55 ` David Miller
2017-11-15 11:42 ` Ahmed Abdelsalam [this message]
2017-11-15 13:37 ` David Miller
2017-11-15 0:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115124202.bcb98eba1523e6957b34ccaf@gmail.com \
--to=amsalam20@gmail.com \
--cc=davem@davemloft.net \
--cc=david.lebrun@uclouvain.be \
--cc=ecree@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).