From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API
Date: Thu, 16 Nov 2017 10:44:07 +0900 (KST)
Message-ID: <20171116.104407.141002935068271606.davem@davemloft.net>
References: <20171031124145.9667-1-bjorn.topel@gmail.com>
        <20171031124145.9667-2-bjorn.topel@gmail.com>
        <CAAsGZS6zC9G2oe_4q_hRL=G=2=Yr5h_KL3RmrE-OCyHNnpz5pQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: bjorn.topel@gmail.com, magnus.karlsson@intel.com,
        alexander.h.duyck@intel.com, alexander.duyck@gmail.com,
        john.fastabend@gmail.com, ast@fb.com, brouer@redhat.com,
        michael.lundkvist@ericsson.com, ravineet.singh@ericsson.com,
        daniel@iogearbox.net, netdev@vger.kernel.org,
        bjorn.topel@intel.com, jesse.brandeburg@intel.com,
        anjali.singhai@intel.com, rami.rosen@intel.com,
        jeffrey.b.shaw@intel.com, ferruh.yigit@intel.com,
        qi.z.zhang@intel.com
To: loke.chetan@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:37866 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754587AbdKPBoO (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 15 Nov 2017 20:44:14 -0500
In-Reply-To: <CAAsGZS6zC9G2oe_4q_hRL=G=2=Yr5h_KL3RmrE-OCyHNnpz5pQ@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: chet l <loke.chetan@gmail.com>
Date: Wed, 15 Nov 2017 14:34:32 -0800

> I have not reviewed the entire patchset but I think if we could add a
> version_hdr and then unionize the fields, it might be easier to add
> SVM support without having to spin v5. I could be wrong though.

Please, NO VERSION FIELDS!

Design things properly from the start rather than using a crutch of
being able to "adjust things later".