From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v3] wcn36xx: Set default BTLE coexistence config Date: Wed, 15 Nov 2017 22:33:17 -0800 Message-ID: <20171116063317.GM28761@minitux> References: <20171114072319.32705-1-rfried@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, k.eugene.e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, wcn36xx-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, nicolas.dechesne-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Eyal Ilsar To: Ramon Fried Return-path: Content-Disposition: inline In-Reply-To: <20171114072319.32705-1-rfried-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Mon 13 Nov 23:23 PST 2017, Ramon Fried wrote: > From: Eyal Ilsar > > If the value for the firmware configuration parameters > BTC_STATIC_LEN_LE_BT and BTC_STATIC_LEN_LE_WLAN are not set the duty > cycle between BT and WLAN is such that if BT (including BLE) is active > WLAN gets 0 bandwidth. When tuning these parameters having a too high > value for WLAN means that BLE performance degrades. > The "sweet" point of roughly half of the maximal values was empirically > found to achieve a balance between BLE and Wi-Fi coexistence > performance. > > Signed-off-by: Eyal Ilsar > Signed-off-by: Ramon Fried > --- > drivers/net/wireless/ath/wcn36xx/smd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c > index 9c6590d5348a..1c7598752255 100644 > --- a/drivers/net/wireless/ath/wcn36xx/smd.c > +++ b/drivers/net/wireless/ath/wcn36xx/smd.c > @@ -72,8 +72,10 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[] = { > WCN36XX_CFG_VAL(DYNAMIC_PS_POLL_VALUE, 0), > WCN36XX_CFG_VAL(TX_PWR_CTRL_ENABLE, 1), > WCN36XX_CFG_VAL(ENABLE_CLOSE_LOOP, 1), > - WCN36XX_CFG_VAL(ENABLE_LPWR_IMG_TRANSITION, 0), I still don't see why you're moving this unrelated line, can you please help me see what I'm missing? Thanks, Bjorn > + WCN36XX_CFG_VAL(BTC_STATIC_LEN_LE_BT, 120000), > + WCN36XX_CFG_VAL(BTC_STATIC_LEN_LE_WLAN, 30000), > WCN36XX_CFG_VAL(MAX_ASSOC_LIMIT, 10), > + WCN36XX_CFG_VAL(ENABLE_LPWR_IMG_TRANSITION, 0), > WCN36XX_CFG_VAL(ENABLE_MCC_ADAPTIVE_SCHEDULER, 0), > }; > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >