From: Andrew Lunn <andrew@lunn.ch>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Eran Ben Elisha <eranbe@mellanox.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"John W. Linville" <linville@tuxdriver.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Gal Pressman <galp@mellanox.com>,
Ariel Almog <ariela@mellanox.com>,
Inbar Karmy <inbark@mellanox.com>
Subject: Re: [RFC PATCH net-next 0/2] Configuring PFC stall prevention via ethtool
Date: Thu, 16 Nov 2017 16:42:12 +0100 [thread overview]
Message-ID: <20171116154212.GE7627@lunn.ch> (raw)
In-Reply-To: <20171116084406.cqs4msohou5z2c5k@unicorn.suse.cz>
> I don't like adding another ethtool_ops callback tightly tied to the
> structures passed via ioctl() but when I started to think what to
> suggest as an alternative, I started to wonder if it is really necessary
> to add a new ethtool command at all. Couldn't this be handled as
> a tunable?
I agree with Michal here.
And as he pointed out, there does not need to be a 1:1 mapping between
ethtool(1) and the kAPI. I suggest extending the existing -a option,
and have it make two system calls if needed.
Andrew
next prev parent reply other threads:[~2017-11-16 15:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 19:00 [RFC PATCH net-next 0/2] Configuring PFC stall prevention via ethtool Eran Ben Elisha
2017-11-15 19:00 ` [RFC PATCH net-next 1/2] ethtool: Add support for configuring PFC stall prevention in ethtool Eran Ben Elisha
2017-11-15 19:00 ` [RFC PATCH net-next 2/2] net/mlx5e: PFC stall prevention support Eran Ben Elisha
2017-11-16 1:07 ` [RFC PATCH net-next 0/2] Configuring PFC stall prevention via ethtool Andrew Lunn
2017-11-16 2:44 ` Andrew Lunn
2017-11-16 9:17 ` Eran Ben Elisha
2017-11-16 15:22 ` Andrew Lunn
2017-11-16 8:44 ` Michal Kubecek
2017-11-16 12:03 ` Eran Ben Elisha
2017-11-16 12:39 ` Michal Kubecek
2017-11-16 15:42 ` Andrew Lunn [this message]
2017-11-20 11:47 ` Eran Ben Elisha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116154212.GE7627@lunn.ch \
--to=andrew@lunn.ch \
--cc=ariela@mellanox.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=galp@mellanox.com \
--cc=inbark@mellanox.com \
--cc=linville@tuxdriver.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).