From: Stephen Hemminger <stephen@networkplumber.org>
To: Jon Maloy <jon.maloy@ericsson.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<mohan.krishna.ghanta.krishnamurthy@ericsson.com>,
<tung.q.nguyen@dektech.com.au>, <hoang.h.le@dektech.com.au>,
<canh.d.luu@dektech.com.au>, <ying.xue@windriver.com>,
<tipc-discussion@lists.sourceforge.net>,
Jiri Pirko <jiri@mellanox.com>
Subject: Re: [iproute2 1/1] tipc: change family attribute from u32 to u16
Date: Thu, 16 Nov 2017 16:00:47 -0800 [thread overview]
Message-ID: <20171116160047.20ee5850@xeon-e3> (raw)
In-Reply-To: <1510763144-24668-1-git-send-email-jon.maloy@ericsson.com>
On Wed, 15 Nov 2017 17:25:44 +0100
Jon Maloy <jon.maloy@ericsson.com> wrote:
> commit 28033ae4e0f ("net: netlink: Update attr validation to require
> exact length for some types") introduces a stricter control on attributes
> of type NLA_U* and NLA_S*.
>
> Since the tipc tool is sending a family attribute of u32 instead of as
> expected u16 the tool is now effectively broken.
>
> We fix this by changing the type of the said attribute.
>
> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Applied.
I noticed devlink has the same problem!
devlink/mnlg.c: mnl_attr_put_u32(nlh, CTRL_ATTR_FAMILY_ID, nlg->id);
prev parent reply other threads:[~2017-11-17 0:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 16:25 [iproute2 1/1] tipc: change family attribute from u32 to u16 Jon Maloy
2017-11-17 0:00 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116160047.20ee5850@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=canh.d.luu@dektech.com.au \
--cc=davem@davemloft.net \
--cc=hoang.h.le@dektech.com.au \
--cc=jiri@mellanox.com \
--cc=jon.maloy@ericsson.com \
--cc=mohan.krishna.ghanta.krishnamurthy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tung.q.nguyen@dektech.com.au \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).