From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [iproute2  1/1] tipc: change family attribute from u32 to u16
Date: Thu, 16 Nov 2017 16:00:47 -0800
Message-ID: <20171116160047.20ee5850@xeon-e3>
References: <1510763144-24668-1-git-send-email-jon.maloy@ericsson.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <mohan.krishna.ghanta.krishnamurthy@ericsson.com>,
        <tung.q.nguyen@dektech.com.au>, <hoang.h.le@dektech.com.au>,
        <canh.d.luu@dektech.com.au>, <ying.xue@windriver.com>,
        <tipc-discussion@lists.sourceforge.net>,
        Jiri Pirko <jiri@mellanox.com>
To: Jon Maloy <jon.maloy@ericsson.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f176.google.com ([209.85.192.176]:35445 "EHLO
        mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752903AbdKQAAz (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 16 Nov 2017 19:00:55 -0500
Received: by mail-pf0-f176.google.com with SMTP id d28so570237pfe.2
        for <netdev@vger.kernel.org>; Thu, 16 Nov 2017 16:00:55 -0800 (PST)
In-Reply-To: <1510763144-24668-1-git-send-email-jon.maloy@ericsson.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 15 Nov 2017 17:25:44 +0100
Jon Maloy <jon.maloy@ericsson.com> wrote:

> commit 28033ae4e0f ("net: netlink: Update attr validation to require
> exact length for some types") introduces a stricter control on attributes
> of type NLA_U* and NLA_S*.
> 
> Since the tipc tool is sending a family attribute of u32 instead of as
> expected u16 the tool is now effectively broken.
> 
> We fix this by changing the type of the said attribute.
> 
> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>

Applied.

I noticed devlink has the same problem!
devlink/mnlg.c: mnl_attr_put_u32(nlh, CTRL_ATTR_FAMILY_ID, nlg->id);