From: David Miller <davem@davemloft.net>
To: jan.kundrat@cesnet.cz
Cc: netdev@vger.kernel.org, rmk+kernel@arm.linux.org.uk,
f.fainelli@gmail.com, andrew@lunn.ch
Subject: Re: [PATCH] sfp: Add support for DWDM SFP modules
Date: Fri, 17 Nov 2017 14:58:05 +0900 (KST) [thread overview]
Message-ID: <20171117.145805.1791714892851517653.davem@davemloft.net> (raw)
In-Reply-To: <5226d9535b31269e0388b781ef815ee2183ee3b9.1510745986.git.jan.kundrat@cesnet.cz>
From: Jan Kundrát <jan.kundrat@cesnet.cz>
Date: Wed, 15 Nov 2017 12:39:33 +0100
> Without this patch, but with CONFIG_SFP enabled, my NIC won't detect
> module unplugging, which is suboptimal.
>
> I'm using an OEM "Cisco compatible" DWDM fixed-frequency 100Ghz-grid SFP
> module. It reports itself as a 0x0b 0x24. According to SFF-8024, byte 0
> value "0Bh" refers to a "DWDM-SFP/SFP+ (not using SFF-8472)". In
> practice, there's a lot of shared properties here.
>
> Everything is apparently defined in a document called "DWDM SFP MSA
> (Multi-source Agreement), Revision 1.0, 19th September 2005". I don't
> have access to that ocument (yet). Its likely source, the
> http://www.dwdmsfpmsa.org/ has been down for years.
>
> From the datasheets that I was able to find on random vendors' web, the
> second byte can vary -- 0x27 is used, too.
>
> Tested on Clearfog Base with v4.14 and Russell King's SFP patches.
>
> Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>
Russell, Florian, Amdrew, can I get a review?
next prev parent reply other threads:[~2017-11-17 5:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 11:39 [PATCH] sfp: Add support for DWDM SFP modules Jan Kundrát
2017-11-17 5:58 ` David Miller [this message]
2017-11-17 9:52 ` Russell King - ARM Linux
2017-11-17 14:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117.145805.1791714892851517653.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=jan.kundrat@cesnet.cz \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).