From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next] dt-bindings: net: dsa: Document additional
 Microchip KSZ family switches
Date: Fri, 17 Nov 2017 04:57:05 +0100
Message-ID: <20171117035705.GD27450@lunn.ch>
References: <1510886535-5506-1-git-send-email-Tristram.Ha@microchip.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Pavel Machek <pavel@ucw.cz>, UNGLinuxDriver@microchip.com,
        netdev@vger.kernel.org
To: Tristram.Ha@microchip.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:58164 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932283AbdKQD5I (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 16 Nov 2017 22:57:08 -0500
Content-Disposition: inline
In-Reply-To: <1510886535-5506-1-git-send-email-Tristram.Ha@microchip.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> +		ksz9477: ksz9477@0 {
> +			compatible = "microchip,ksz9477";
> +			reg = <0>;
>  
> -                                                             spi-max-frequency = <44000000>;
> -                                                             spi-cpha;
> -                                                             spi-cpol;
> +			spi-max-frequency = <44000000>;
> +			spi-cpha;
> +			spi-cpol;

...

> +
> +		};
> +		ksz8794: ksz8794@0 {
> +			compatible = "microchip,ksz8794";
> +			reg = <0>;
> +
> +			spi-max-frequency = <30000000>;
> +			spi-cpha;
> +			spi-cpol;
> +
> +			};

...

> +		};
> +		ksz8864: ksz8864@0 {
> +			compatible = "microchip,ksz8864";
> +			reg = <0>;
> +
> +			spi-max-frequency = <12000000>;
> +			spi-cpha;
> +			spi-cpol;
> +
...
> +		};
> +	};

Hi Tristram

Nitpick. These all appear to be on the same SPI bus. So they should
have different reg values.

Also, the label is supposed to be generic, not specific. So switch0:
ksz9477@0, switch1: ksz8794@1, etc.

	   Andrew