From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2/net-next v3]tc: B.W limits can now be specified
 in %.
Date: Fri, 17 Nov 2017 13:12:58 -0800
Message-ID: <20171117131258.194d2941@xeon-e3>
References: <20171117204335.GA17658@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, doucette@bu.edu, michel.machado@gmail.com
To: Nishanth Devarajan <ndev2021@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f67.google.com ([74.125.83.67]:34642 "EHLO
        mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753050AbdKQVNG (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 17 Nov 2017 16:13:06 -0500
Received: by mail-pg0-f67.google.com with SMTP id 4so2822737pge.1
        for <netdev@vger.kernel.org>; Fri, 17 Nov 2017 13:13:06 -0800 (PST)
In-Reply-To: <20171117204335.GA17658@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sat, 18 Nov 2017 02:13:38 +0530
Nishanth Devarajan <ndev2021@gmail.com> wrote:

> diff --git a/tc/tc_util.h b/tc/tc_util.h
> index 583a21a..7b7420a 100644
> --- a/tc/tc_util.h
> +++ b/tc/tc_util.h
> @@ -24,14 +24,14 @@ struct qdisc_util {
>  	struct  qdisc_util *next;
>  	const char *id;
>  	int (*parse_qopt)(struct qdisc_util *qu, int argc,
> -			  char **argv, struct nlmsghdr *n);
> +			  char **argv, struct nlmsghdr *n, char *dev);

One more nit...
Since parsing queue options should not modify the device name, that should
be const char *.