From: Andrew Lunn <andrew@lunn.ch>
To: Tristram.Ha@microchip.com
Cc: davem@davemloft.net, f.fainelli@gmail.com, pavel@ucw.cz,
arkadis@mellanox.com, UNGLinuxDriver@microchip.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 net-next 0/7] net: dsa: microchip: Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers
Date: Fri, 17 Nov 2017 20:51:03 +0100 [thread overview]
Message-ID: <20171117195103.GA13299@lunn.ch> (raw)
In-Reply-To: <93AF473E2DA327428DE3D46B72B1E9FD41139D98@CHN-SV-EXMX02.mchp-main.com>
> I really need to monitor the DSA discussion to better contribute to its success.
> I just found out the DSA API set_addr was removed last month due to not
> everybody is using it. It cited the Marvell switch was the only switch using that
> API and found a new way to program the MAC address. But looking at that
> driver I found it simply uses a randomized MAC address.
>
> For big switch with many ports where the main function is forwarding that MAC
> address may not matter. For small switch with 2 ports it acts more like an Ethernet
> controller where the switch is mainly used for daisy chaining in a ring network the MAC
> address can be used in feature like source address filtering.
Hi Tristram
The MAC address set by set_addr was only used for pause
frames. Nothing else. So a random address is fine.
The switch itself should not be sending any other frames.
Andrew
next prev parent reply other threads:[~2017-11-17 19:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 2:41 [PATCH v1 net-next 0/7] net: dsa: microchip: Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers Tristram.Ha
2017-11-17 2:41 ` [PATCH v1 net-next 1/7] net: dsa: microchip: Replace license with GPL Tristram.Ha
2017-11-17 3:49 ` Andrew Lunn
2017-11-17 2:41 ` [PATCH v1 net-next 2/7] net: dsa: microchip: Clean up code according to patch check suggestions Tristram.Ha
2017-11-17 2:41 ` [PATCH v1 net-next 3/7] net: dsa: microchip: Rename some functions with ksz9477 prefix chip specific code from common code Tristram.Ha
2017-11-17 2:41 ` [PATCH v1 net-next 4/7] net: dsa: microchip: Rename ksz_spi.c to ksz9477_spi.c Tristram.Ha
2017-11-17 2:41 ` [PATCH v1 net-next 5/7] net: dsa: microchip: Break KSZ9477 DSA driver into two files Tristram.Ha
2017-11-17 2:41 ` [PATCH v1 net-next 6/7] net: dsa: microchip: Prepare PHY for proper advertisement Tristram.Ha
2017-11-17 2:41 ` [PATCH v1 net-next 7/7] net: dsa: microchip: Rename ksz_9477_reg.h to ksz9477_reg.h Tristram.Ha
2017-11-17 3:48 ` Andrew Lunn
2017-11-17 3:44 ` [PATCH v1 net-next 0/7] net: dsa: microchip: Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers Andrew Lunn
2017-11-17 19:33 ` Tristram.Ha
2017-11-17 19:51 ` Andrew Lunn [this message]
2017-11-18 23:40 ` Tristram.Ha
2017-11-17 5:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117195103.GA13299@lunn.ch \
--to=andrew@lunn.ch \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=arkadis@mellanox.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).