From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v1 net-next 0/7] net: dsa: microchip: Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers Date: Fri, 17 Nov 2017 20:51:03 +0100 Message-ID: <20171117195103.GA13299@lunn.ch> References: <1510886491-5459-1-git-send-email-Tristram.Ha@microchip.com> <20171117034427.GA27450@lunn.ch> <93AF473E2DA327428DE3D46B72B1E9FD41139D98@CHN-SV-EXMX02.mchp-main.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, f.fainelli@gmail.com, pavel@ucw.cz, arkadis@mellanox.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org To: Tristram.Ha@microchip.com Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:58779 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934125AbdKQTvM (ORCPT ); Fri, 17 Nov 2017 14:51:12 -0500 Content-Disposition: inline In-Reply-To: <93AF473E2DA327428DE3D46B72B1E9FD41139D98@CHN-SV-EXMX02.mchp-main.com> Sender: netdev-owner@vger.kernel.org List-ID: > I really need to monitor the DSA discussion to better contribute to its success. > I just found out the DSA API set_addr was removed last month due to not > everybody is using it. It cited the Marvell switch was the only switch using that > API and found a new way to program the MAC address. But looking at that > driver I found it simply uses a randomized MAC address. > > For big switch with many ports where the main function is forwarding that MAC > address may not matter. For small switch with 2 ports it acts more like an Ethernet > controller where the switch is mainly used for daisy chaining in a ring network the MAC > address can be used in feature like source address filtering. Hi Tristram The MAC address set by set_addr was only used for pause frames. Nothing else. So a random address is fine. The switch itself should not be sending any other frames. Andrew