From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] route: also update fnhe_genid when updating a route cache Date: Sat, 18 Nov 2017 10:35:14 +0900 (KST) Message-ID: <20171118.103514.756262305568015490.davem@davemloft.net> References: <636380e5869b655e9fa9cb296c690d2e1a48c6f3.1510900038.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, hannes@stressinduktion.org, pabeni@redhat.com To: lucien.xin@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:38168 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423932AbdKRBfR (ORCPT ); Fri, 17 Nov 2017 20:35:17 -0500 In-Reply-To: <636380e5869b655e9fa9cb296c690d2e1a48c6f3.1510900038.git.lucien.xin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Xin Long Date: Fri, 17 Nov 2017 14:27:18 +0800 > Now when ip route flush cache and it turn out all fnhe_genid != genid. > If a redirect/pmtu icmp packet comes and the old fnhe is found and all > it's members but fnhe_genid will be updated. > > Then next time when it looks up route and tries to rebind this fnhe to > the new dst, the fnhe will be flushed due to fnhe_genid != genid. It > causes this redirect/pmtu icmp packet acutally not to be applied. > > This patch is to also reset fnhe_genid when updating a route cache. > > Fixes: 5aad1de5ea2c ("ipv4: use separate genid for next hop exceptions") > Acked-by: Hannes Frederic Sowa > Signed-off-by: Xin Long Applied.