From: David Miller <davem@davemloft.net>
To: girish.moodalbail@oracle.com
Cc: netdev@vger.kernel.org, mahesh@bandewar.net
Subject: Re: [PATCH net v2 1/1] ipvlan: NULL pointer dereference panic in ipvlan_port_destroy
Date: Sat, 18 Nov 2017 10:37:29 +0900 (KST) [thread overview]
Message-ID: <20171118.103729.433267100989647193.davem@davemloft.net> (raw)
In-Reply-To: <1510902977-7931-2-git-send-email-girish.moodalbail@oracle.com>
From: Girish Moodalbail <girish.moodalbail@oracle.com>
Date: Thu, 16 Nov 2017 23:16:17 -0800
> When call to register_netdevice() (called from ipvlan_link_new()) fails,
> we call ipvlan_uninit() (through ndo_uninit()) to destroy the ipvlan
> port. After returning unsuccessfully from register_netdevice() we go
> ahead and call ipvlan_port_destroy() again which causes NULL pointer
> dereference panic. Fix the issue by making ipvlan_init() and
> ipvlan_uninit() call symmetric.
>
> The ipvlan port will now be created inside ipvlan_init() and will be
> destroyed in ipvlan_uninit().
>
> Fixes: 2ad7bf363841 (ipvlan: Initial check-in of the IPVLAN driver)
> Signed-off-by: Girish Moodalbail <girish.moodalbail@oracle.com>
Applied.
prev parent reply other threads:[~2017-11-18 1:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 7:16 [PATCH net v2 0/1] NULL pointer dereference in ipvlan_port_destroy Girish Moodalbail
2017-11-17 7:16 ` [PATCH net v2 1/1] ipvlan: NULL pointer dereference panic " Girish Moodalbail
2017-11-18 1:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171118.103729.433267100989647193.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=girish.moodalbail@oracle.com \
--cc=mahesh@bandewar.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).