From: David Miller <davem@davemloft.net>
To: alexey.kodanev@oracle.com
Cc: netdev@vger.kernel.org, tom@herbertland.com
Subject: Re: [PATCH 2/2] ip6_tunnel: pass tun_dst arg from ip6_tnl_rcv() to __ip6_tnl_rcv()
Date: Sun, 19 Nov 2017 12:22:00 +0900 (KST) [thread overview]
Message-ID: <20171119.122200.1034138931090068127.davem@davemloft.net> (raw)
In-Reply-To: <1510935378-11226-2-git-send-email-alexey.kodanev@oracle.com>
From: Alexey Kodanev <alexey.kodanev@oracle.com>
Date: Fri, 17 Nov 2017 19:16:18 +0300
> Otherwise tun_dst argument is unused there. Currently, ip6_tnl_rcv()
> invoked with tun_dst set to NULL, so there is no actual functional
> changes introduced in this patch.
Oh yes there is a functional change, becaue __ip6_tnl_rcv() is also
used by ipxip6_rcv() which can pass a non-NULL tnl_dst.
If anything, you commit log message is inaccurate and you need to
investigate the implications of this functional change.
next prev parent reply other threads:[~2017-11-19 3:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 16:16 [PATCH 1/2] gre6: use log_ecn_error module parameter in ip6_tnl_rcv() Alexey Kodanev
2017-11-17 16:16 ` [PATCH 2/2] ip6_tunnel: pass tun_dst arg from ip6_tnl_rcv() to __ip6_tnl_rcv() Alexey Kodanev
2017-11-19 3:22 ` David Miller [this message]
2017-11-20 11:07 ` Alexey Kodanev
2017-11-19 3:22 ` [PATCH 1/2] gre6: use log_ecn_error module parameter in ip6_tnl_rcv() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171119.122200.1034138931090068127.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexey.kodanev@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).