From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH 2/2] ip6_tunnel: pass tun_dst arg from ip6_tnl_rcv() to
 __ip6_tnl_rcv()
Date: Sun, 19 Nov 2017 12:22:00 +0900 (KST)
Message-ID: <20171119.122200.1034138931090068127.davem@davemloft.net>
References: <1510935378-11226-1-git-send-email-alexey.kodanev@oracle.com>
        <1510935378-11226-2-git-send-email-alexey.kodanev@oracle.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, tom@herbertland.com
To: alexey.kodanev@oracle.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:49408 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750781AbdKSDWI (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 18 Nov 2017 22:22:08 -0500
In-Reply-To: <1510935378-11226-2-git-send-email-alexey.kodanev@oracle.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Alexey Kodanev <alexey.kodanev@oracle.com>
Date: Fri, 17 Nov 2017 19:16:18 +0300

> Otherwise tun_dst argument is unused there. Currently, ip6_tnl_rcv()
> invoked with tun_dst set to NULL, so there is no actual functional
> changes introduced in this patch.

Oh yes there is a functional change, becaue __ip6_tnl_rcv() is also
used by ipxip6_rcv() which can pass a non-NULL tnl_dst.

If anything, you commit log message is inaccurate and you need to
investigate the implications of this functional change.