From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 0/2] net: fix flowlabel inconsistency in reset
 packet
Date: Sun, 19 Nov 2017 12:26:49 +0900 (KST)
Message-ID: <20171119.122649.2026336849128072376.davem@davemloft.net>
References: <cover.1510942659.git.shli@fb.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, kafai@fb.com, eric.dumazet@gmail.com,
        flo@fourcot.fr, xiyou.wangcong@gmail.com, tom@herbertland.com,
        Kernel-team@fb.com, shli@fb.com
To: shli@kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:49480 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751076AbdKSD0x (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 18 Nov 2017 22:26:53 -0500
In-Reply-To: <cover.1510942659.git.shli@fb.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Shaohua Li <shli@kernel.org>
Date: Fri, 17 Nov 2017 10:24:49 -0800

> From: Shaohua Li <shli@fb.com>
> 
> Hi,
> 
> Please see below tcpdump output:
...
> The tcp reset packet has a different flowlabel, which causes our router
> doesn't correctly close tcp connection. We are using flowlabel to do
> load balance. Routers in the path maintain connection state. So if flow
> label changes, the packet is routed through a different router. In this
> case, the old router doesn't get the reset packet to close the tcp
> connection.
> 
> The reason is the normal packet gets the skb->hash from sk->sk_txhash,
> which is generated randomly. ip6_make_flowlabel then uses the hash to
> create a flowlabel. The reset packet doesn't get assigned a hash, so the
> flowlabel is calculated with flowi6.
> 
> The patches fix the issue.

Please resubmit this when the net-next tree opens back up as it is
closed right now, thank you.