From: David Miller <davem@davemloft.net>
To: netanel@amazon.com
Cc: netdev@vger.kernel.org, dwmw@amazon.com, zorik@amazon.com,
matua@amazon.com, saeedb@amazon.com, msw@amazon.com,
aliguori@amazon.com, nafea@amazon.com, evgenys@amazon.com
Subject: Re: [PATCH net] net: ena: fix race condition between device reset and link up setup
Date: Sun, 19 Nov 2017 12:40:10 +0900 (KST) [thread overview]
Message-ID: <20171119.124010.1303273954049036187.davem@davemloft.net> (raw)
In-Reply-To: <1510974336-105124-1-git-send-email-netanel@amazon.com>
From: <netanel@amazon.com>
Date: Sat, 18 Nov 2017 03:05:36 +0000
> From: Netanel Belgazal <netanel@amazon.com>
>
> In rare cases, ena driver would reset and re-start the device,
> for example, in case of misbehaving application that causes
> transmit timeout
>
> The first step in the reset procedure is to stop the Tx traffic by
> calling ena_carrier_off().
>
> After the driver have just started the device reset procedure, device
> happens to send an asynchronous notification (via AENQ) to the driver
> than there was a link change (to link-up state).
> This link change is mapped to a call to netif_carrier_on() which
> re-activates the Tx queues, violating the assumption of no tx traffic
> until device reset is completed, as the reset task might still be in
> the process of queues initialization, leading to an access to
> uninitialized memory.
This patch lacks a proper Signed-off-by: tag.
Please resubmit with this corrected.
Thank you.
next prev parent reply other threads:[~2017-11-19 3:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 3:05 [PATCH net] net: ena: fix race condition between device reset and link up setup netanel
2017-11-19 3:40 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-11-19 18:03 netanel
2017-11-20 2:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171119.124010.1303273954049036187.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aliguori@amazon.com \
--cc=dwmw@amazon.com \
--cc=evgenys@amazon.com \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).