From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: nic_swsd@realtek.com, hau@realtek.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] r8169: use same RTL8111EVL green settings as in vendor driver
Date: Sun, 19 Nov 2017 15:44:54 +0900 (KST) [thread overview]
Message-ID: <20171119.154454.2030592370938773133.davem@davemloft.net> (raw)
In-Reply-To: <68b1459f-beea-cafa-23de-fa71f02e143c@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sun, 19 Nov 2017 01:36:02 +0100
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 19f3074a0..912549c88 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -3810,6 +3810,11 @@ static void rtl8168e_2_hw_phy_config(struct rtl8169_private *tp)
> rtl_w0w1_phy(tp, 0x19, 0x0001, 0x0000);
> rtl_w0w1_phy(tp, 0x10, 0x0400, 0x0000);
> rtl_writephy(tp, 0x1f, 0x0000);
> + rtl_writephy(tp, 0x1f, 0x0005);
> + rtl_w0w1_phy(tp, 0x01, 0x0100, 0x0000);
> + rtl_writephy(tp, 0x1f, 0x0000);
> + /* soft-reset phy */
> + rtl_writephy(tp, 0x00, 0x9200);
Please do not use magic constants when writing to the MII_BMCR in page
zero of the PHY. These register offsets and register bit fields have
defines in <linux/mii.h", so please use them.
prev parent reply other threads:[~2017-11-19 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-19 0:33 [PATCH 1/2] r8169: fix RTL8111EVL EEE and green settings Heiner Kallweit
2017-11-19 0:36 ` [PATCH 2/2] r8169: use same RTL8111EVL green settings as in vendor driver Heiner Kallweit
2017-11-19 6:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171119.154454.2030592370938773133.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hau@realtek.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).