From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/2] r8169: use same RTL8111EVL green settings as in vendor driver Date: Sun, 19 Nov 2017 15:44:54 +0900 (KST) Message-ID: <20171119.154454.2030592370938773133.davem@davemloft.net> References: <039e4546-d855-a70d-508a-caf6201ffc44@gmail.com> <68b1459f-beea-cafa-23de-fa71f02e143c@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: nic_swsd@realtek.com, hau@realtek.com, netdev@vger.kernel.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:50544 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbdKSGvx (ORCPT ); Sun, 19 Nov 2017 01:51:53 -0500 In-Reply-To: <68b1459f-beea-cafa-23de-fa71f02e143c@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Sun, 19 Nov 2017 01:36:02 +0100 > diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c > index 19f3074a0..912549c88 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -3810,6 +3810,11 @@ static void rtl8168e_2_hw_phy_config(struct rtl8169_private *tp) > rtl_w0w1_phy(tp, 0x19, 0x0001, 0x0000); > rtl_w0w1_phy(tp, 0x10, 0x0400, 0x0000); > rtl_writephy(tp, 0x1f, 0x0000); > + rtl_writephy(tp, 0x1f, 0x0005); > + rtl_w0w1_phy(tp, 0x01, 0x0100, 0x0000); > + rtl_writephy(tp, 0x1f, 0x0000); > + /* soft-reset phy */ > + rtl_writephy(tp, 0x00, 0x9200); Please do not use magic constants when writing to the MII_BMCR in page zero of the PHY. These register offsets and register bit fields have defines in